chore: add lgtm PR analysis

BlueBrain · Jan 18, 2019 · 1047be2 · 1047be2
1 parent 3ad948e
commit 1047be2
Show file tree

Hide file tree

Showing 11 changed files with 24 additions and 6 deletions.
diff --git a/.lgtm.yml b/.lgtm.yml
@@ -0,0 +1,9 @@
+extraction:
+  cpp:
+    prepare:
+      packages:
+        - libwebsockets-dev
+        - libuv1-dev
+  python:
+    python_setup:
+      version: 3
diff --git a/README.md b/README.md
@@ -3,6 +3,7 @@
 > A library for easy HTTP and websockets messaging in C++ applications.
 
 [![Travis CI](https://img.shields.io/travis/BlueBrain/Rockets/master.svg?style=flat-square)](https://travis-ci.org/BlueBrain/Rockets)
+[![Language grade: C/C++](https://img.shields.io/lgtm/grade/cpp/g/BlueBrain/Rockets.svg?logo=lgtm&logoWidth=18)](https://lgtm.com/projects/g/BlueBrain/Rockets/context:cpp)
 
 
 # Table of Contents

diff --git a/js/README.md b/js/README.md
@@ -3,6 +3,7 @@
 > A small client for [Rockets](../README.md) using [JSON RPC](https://www.jsonrpc.org) as communication contract over a [WebSocket](https://developer.mozilla.org/en-US/docs/Web/API/WebSocket).
 
 [![Travis CI](https://img.shields.io/travis/BlueBrain/Rockets/master.svg?style=flat-square)](https://travis-ci.org/BlueBrain/Rockets)
+[![Language grade: JavaScript](https://img.shields.io/lgtm/grade/javascript/g/BlueBrain/Rockets.svg?logo=lgtm&logoWidth=18)](https://lgtm.com/projects/g/BlueBrain/Rockets/context:javascript)
 
 
 # Table of Contents

diff --git a/python/README.md b/python/README.md
@@ -8,6 +8,7 @@
 [![Latest version](https://img.shields.io/pypi/v/rockets.svg)](https://pypi.org/project/rockets/)
 [![Python versions](https://img.shields.io/pypi/pyversions/rockets.svg)](https://pypi.org/project/rockets/)
 [![Code style: black](https://img.shields.io/badge/code%20style-black-000000.svg)](https://github.com/ambv/black)
+[![Language grade: Python](https://img.shields.io/lgtm/grade/python/g/BlueBrain/Rockets.svg?logo=lgtm&logoWidth=18)](https://lgtm.com/projects/g/BlueBrain/Rockets/context:python)
 
 
 # Table of Contents

diff --git a/rockets/http/client.cpp b/rockets/http/client.cpp
@@ -132,7 +132,7 @@ std::future<Response> Client::request(const std::string& uri,
                                       const Method method, std::string body)
 {
     auto promise = std::make_shared<std::promise<Response>>();
-    auto callback = [promise](Response response) {
+    auto callback = [promise](Response&& response) {
         promise->set_value(std::move(response));
     };
     auto errorCallback = [promise](std::string e) {

diff --git a/rockets/jsonrpc/asyncReceiverImpl.h b/rockets/jsonrpc/asyncReceiverImpl.h
@@ -17,6 +17,8 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
+#pragma once
+
 #include "receiverImpl.h"
 #include "utils.h"
 
@@ -50,7 +52,7 @@ class AsyncReceiverImpl : public ReceiverImpl
         }
 
         const auto& func = _methods[method];
-        func(request, [respond, requestID](const Response rep) {
+        func(request, [respond, requestID](const Response& rep) {
             // No reply for valid "notifications" (requests without an "id")
             if (requestID.is_null())
                 respond(json());

diff --git a/rockets/jsonrpc/cancellableReceiverImpl.h b/rockets/jsonrpc/cancellableReceiverImpl.h
@@ -17,6 +17,8 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
+#pragma once
+
 #include "asyncReceiverImpl.h"
 #include "helpers.h"
 #include "utils.h"

diff --git a/rockets/jsonrpc/http.cpp b/rockets/jsonrpc/http.cpp
@@ -49,7 +49,7 @@ void HttpCommunicator::sendText(std::string message)
     // http::Client (which aborts pending requests, calling the error callback).
     const auto& cb = callback;
     client.request(url, http::Method::POST, std::move(message),
-                   [cb](http::Response response) {
+                   [cb](http::Response&& response) {
                        if (cb)
                            cb(ws::Request{std::move(response.body)});
                    },

diff --git a/rockets/jsonrpc/receiverImpl.h b/rockets/jsonrpc/receiverImpl.h
@@ -17,6 +17,8 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
+#pragma once
+
 #include "requestProcessor.h"
 #include "utils.h"
 

diff --git a/rockets/jsonrpc/requester.cpp b/rockets/jsonrpc/requester.cpp
@@ -105,7 +105,7 @@ ClientRequest<Response> Requester::request(const std::string& method,
                                            const std::string& params)
 {
     auto promise = std::make_shared<std::promise<Response>>();
-    auto callback = [promise](Response response) {
+    auto callback = [promise](Response&& response) {
         promise->set_value(std::move(response));
     };
     return {request(method, params, callback), promise->get_future(),

diff --git a/rockets/jsonrpc/requester.h b/rockets/jsonrpc/requester.h
@@ -80,7 +80,7 @@ class Requester : public Notifier
                                   const Params& params)
     {
         auto promise = std::make_shared<std::promise<RetVal>>();
-        auto callback = [promise](Response response) {
+        auto callback = [promise](const Response& response) {
             if (response.isError())
                 promise->set_exception(
                     std::make_exception_ptr(response_error(response.error)));
@@ -114,7 +114,7 @@ class Requester : public Notifier
     ClientRequest<RetVal> request(const std::string& method)
     {
         auto promise = std::make_shared<std::promise<RetVal>>();
-        auto callback = [promise](Response response) {
+        auto callback = [promise](const Response& response) {
             if (response.isError())
                 promise->set_exception(
                     std::make_exception_ptr(response_error(response.error)));