free should happen after omp_target_disassociate_ptr

BlueBrain · Dec 10, 2021 · 7cb13a1 · 7cb13a1
1 parent afc45bf
commit 7cb13a1
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/coreneuron/gpu/nrn_acc_manager.cpp b/coreneuron/gpu/nrn_acc_manager.cpp
@@ -82,9 +82,8 @@ void cnrn_target_delete(void* h_ptr, size_t len) {
     {
         d_ptr = h_ptr;
     }
-    // todo: disassociate first or free first
-    omp_target_free(d_ptr, device_id);
     omp_target_disassociate_ptr(h_ptr, device_id);
+    omp_target_free(d_ptr, device_id);
 #else
     throw std::runtime_error("cnrn_target_delete() not implemented without OpenACC/OpenMP and gpu build");
 #endif