-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SF2: Fix loop offsets + tuning #81
Conversation
Why did clippy just remember those unused functions wtf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idk what the implementation details are but lgtm
I'll figure out clippy |
I only added support for some SF2 generators (equivalent of opcodes for SFZ) and how some existing ones were parsed because it was wrong. I tested it and it works fine so dw
Should I wait for your PR about clippy to be merged or are you going to do it afterwards? |
Weird, I wonder why the changes of my last PR show up in this PR as well |
I merged master in sf2-fixes before merging this PR to avoid conflicts, so it shows your commits here. Although in master it doesn't show that I wrote any of your changes so it's all good. |
Yeah usually github is supposed to hide duplicate changes from PRs, it's not supposed to show master's changes in your branch when you update from master, kinda strange but oh well |
Added the coarse offset and looping SF2 zones and fixed support for loop offsets and fine/coarse tuning.
Should fix #80