Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SF2: Fix loop offsets + tuning #81

Merged
merged 5 commits into from
Aug 5, 2024
Merged

SF2: Fix loop offsets + tuning #81

merged 5 commits into from
Aug 5, 2024

Conversation

MyBlackMIDIScore
Copy link
Member

Added the coarse offset and looping SF2 zones and fixed support for loop offsets and fine/coarse tuning.

Should fix #80

@MyBlackMIDIScore
Copy link
Member Author

Why did clippy just remember those unused functions wtf

Copy link
Collaborator

@arduano arduano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk what the implementation details are but lgtm

@arduano
Copy link
Collaborator

arduano commented Aug 4, 2024

I'll figure out clippy

@MyBlackMIDIScore
Copy link
Member Author

idk what the implementation details are but lgtm

I only added support for some SF2 generators (equivalent of opcodes for SFZ) and how some existing ones were parsed because it was wrong. I tested it and it works fine so dw

I'll figure out clippy

Should I wait for your PR about clippy to be merged or are you going to do it afterwards?

@MyBlackMIDIScore MyBlackMIDIScore merged commit 62ed54b into master Aug 5, 2024
1 check passed
@MyBlackMIDIScore MyBlackMIDIScore deleted the sf2-fixes branch August 5, 2024 08:19
@arduano
Copy link
Collaborator

arduano commented Aug 6, 2024

Weird, I wonder why the changes of my last PR show up in this PR as well

@MyBlackMIDIScore
Copy link
Member Author

Weird, I wonder why the changes of my last PR show up in this PR as well

I merged master in sf2-fixes before merging this PR to avoid conflicts, so it shows your commits here. Although in master it doesn't show that I wrote any of your changes so it's all good.

@arduano
Copy link
Collaborator

arduano commented Aug 6, 2024

Yeah usually github is supposed to hide duplicate changes from PRs, it's not supposed to show master's changes in your branch when you update from master, kinda strange but oh well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SF2: Incorrect loop indexes & Realtime: Missed note off events
2 participants