Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean render buffers before writing #79

Merged
merged 1 commit into from
Aug 3, 2024
Merged

Clean render buffers before writing #79

merged 1 commit into from
Aug 3, 2024

Conversation

MyBlackMIDIScore
Copy link
Member

Was a thing in VoiceChannel but not in ChannelGroup or BufferedRenderer and it created confusion.

I think this is the last thing I wanted to do before release. If I remember anything else I'll put it in this PR.

Copy link
Collaborator

@arduano arduano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performance should be negligible I assume

@MyBlackMIDIScore
Copy link
Member Author

Performance should be negligible I assume

I didn't really test this tbh, but I'll run the core benchmarks before I merge. But anyway if this isn't done by the synth itself, it will be done by the program using it so there shouldn't be a difference at the end.

I'll merge this later today (after I do the benchmarks too) in case there's anything else to fix before release.

@arduano
Copy link
Collaborator

arduano commented Aug 3, 2024

Just side note, respond to my email probably, if I sent it to the right email address. Just trying to find a way to contact you that's not public like github issues.

@MyBlackMIDIScore
Copy link
Member Author

Just side note, respond to my email probably, if I sent it to the right email address. Just trying to find a way to contact you that's not public like github issues.

I haven't received anything in my inbox. I'll send you an email to the one you use in your git commits.

@MyBlackMIDIScore
Copy link
Member Author

Just ran the render bench and results were pretty much the same.
Merging this and then I'll create the 0.1.0 tag and release.

@MyBlackMIDIScore MyBlackMIDIScore merged commit 2f805fa into master Aug 3, 2024
1 check passed
@MyBlackMIDIScore MyBlackMIDIScore deleted the fixes branch August 3, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants