dnswatch: add package #4381
Merged
dnswatch: add package #4381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noraj
requested changes
Nov 29, 2024
packages/dnswatch/PKGBUILD
Outdated
| makedepends=('git' 'python-setuptools' 'python-pip') | ||
| source=("$pkgname::git+https://github.com/HalilDeniz/$pkgname.git") | ||
| sha512sums=('SKIP') | ||
| install="$pkgname.install" |
There was a problem hiding this comment.
the dependencies are very easy https://github.com/HalilDeniz/DNSWatch/blob/main/requirements.txt, why did you choose a standalone package?
There was a problem hiding this comment.
Because I gave priority to PKGBUILD Python Standalone template due to the usage of venv. If you think the other PKGBUILD Python template is better, I will change it. Let me know.
There was a problem hiding this comment.
The rule is like that:
- few dependencies, all dependencies already packaged => python-PEP517, python-setuptools or generic-jointscript
- few dependencies, one or two are not packaged yet => same and you package the dependencies with python-lib-setuptools or python-lib-PEP517
- very large number of dependencies => python-standalone
- dependencies that change very often => python-standalone
- requiring outdated version of dependencies, not compatible with the packaged dependencies => python-standalone
It's simple: no venv unless necessary
Co-authored-by: Alexandre ZANNI <[email protected]>
|
thanks guys |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #4003