Moved Multiqueue, invQueue and addrQueue to network module #2256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
anand-skss
commented
Jun 23, 2024
•
anand-skss
commented
- Moved Multiqueue, invQueue and addrQueue to network module
anand-skss
changed the title
anand-skss
force-pushed
the
test3
branch
2 times, most recently
from
cda064e
to
36ecc83
Compare
anand-skss
commented
Jun 23, 2024
| @@ -7,7 +7,7 @@ | |||
| # magic imports! | |||
| import connectionpool | |||
| from protocol import assembleAddrMessage | |||
| from queues import addrQueue # FIXME: init with queue | |||
There was a problem hiding this comment.
Please check Fixme comment, i'm not sure whether i remove this comment or not.
There was a problem hiding this comment.
I'm not sure either, let's leave it as it is.
PeterSurda
approved these changes
Jul 4, 2024
| @@ -7,7 +7,7 @@ | |||
| # magic imports! | |||
| import connectionpool | |||
| from protocol import assembleAddrMessage | |||
| from queues import addrQueue # FIXME: init with queue | |||
There was a problem hiding this comment.
I'm not sure either, let's leave it as it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.