Merge pull request #248 from BitBagCommerce/op-303-api-support

OP-303: Change DataProvider priority
BitBagCommerce · Jun 28, 2024 · a4dd35a · a4dd35a
2 parents 78fbc07 + f876703
commit a4dd35a
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 11 deletions.
diff --git a/src/Api/Resolver/FacetsResolver.php b/src/Api/Resolver/FacetsResolver.php
@@ -47,6 +47,8 @@ public function resolve(array $data): array
             return [];
         }
 
-        return $adapter->getAggregations();
+        return array_filter($adapter->getAggregations(), function ($facet) {
+            return [] !== $facet['buckets'] ?? [];
+        });
     }
 }
diff --git a/src/Resources/config/services/api/data_provider.xml b/src/Resources/config/services/api/data_provider.xml
@@ -6,7 +6,7 @@
             <argument type="service" id="bitbag_sylius_elasticsearch_plugin.api.request_data_handler" />
             <argument type="service" id="bitbag_sylius_elasticsearch_plugin.finder.search_products" />
             <argument type="service" id="bitbag_sylius_elasticsearch_plugin.api.resolver.facets" />
-            <tag name="api_platform.collection_data_provider" />
+            <tag name="api_platform.collection_data_provider" priority="10" />
         </service>
     </services>
 </container>
diff --git a/tests/PHPUnit/Integration/Api/Responses/Expected/test_it_finds_products_by_name.json b/tests/PHPUnit/Integration/Api/Responses/Expected/test_it_finds_products_by_name.json
@@ -22,9 +22,6 @@
         }
     ],
     "facets": {
-        "price": {
-            "buckets": []
-        },
         "taxon": {
             "doc_count_error_upper_bound": 0,
             "sum_other_doc_count": 0,

diff --git a/...PHPUnit/Integration/Api/Responses/Expected/test_it_finds_products_by_name_and_facets.json b/...PHPUnit/Integration/Api/Responses/Expected/test_it_finds_products_by_name_and_facets.json
@@ -32,9 +32,6 @@
         }
       ]
     },
-    "price": {
-      "buckets": []
-    },
     "taxon": {
       "doc_count_error_upper_bound": 0,
       "sum_other_doc_count": 0,

diff --git a/...ntegration/Api/Responses/Expected/test_it_finds_products_by_name_and_multiple_facets.json b/...ntegration/Api/Responses/Expected/test_it_finds_products_by_name_and_multiple_facets.json
@@ -60,9 +60,6 @@
         }
       ]
     },
-    "price": {
-      "buckets": []
-    },
     "taxon": {
       "doc_count_error_upper_bound": 0,
       "sum_other_doc_count": 0,