Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade gradle to 8.2.1 and fix some warnings #92

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

nvervelle
Copy link
Contributor

@nvervelle nvervelle commented Jul 13, 2023

Hi !

Is the project still maintained ? Just want to know if I should send PR here or work on my own fork.

This is just an upgrade of gradle to the current version (allowing Java 17 for example) and fix of a few warnings issued by IntelliJ when committing the files.

I'm also interested in working on #41 , that is being able to use opa in docker for the plugin instead of locally installed opa. Tell me if you would be interested also

@anderseknert
Copy link
Contributor

Hi @nvervelle! And thanks a lot for this contribution. It's vacation time for a lot of us, but I too am hoping this is maintained and will get merged into a new release 🙂

@irodzik irodzik requested review from radrys and SuchSkill July 17, 2023 09:54
@radrys radrys requested a review from irodzik July 17, 2023 09:55
Copy link
Contributor

@irodzik irodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radrys
Copy link
Contributor

radrys commented Jul 17, 2023

Hi @nvervelle ! Thanks for upgrading gradle version. The project is still maintained although not much work is currently going on. Feel free to work on #41 .

@radrys radrys merged commit afe4c81 into Bisnode:master Jul 17, 2023
@nvervelle
Copy link
Contributor Author

Great @radrys , ok I will take a look at #41 for an implementation of either using docker or automatically downloading opa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants