Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Kmers.jl compatibility #282

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jakobnissen
Copy link
Member

This PR is a purely internal one. Since Kmers.jl shares a lot of internals with BioSequences (by design), this PR is intended to make any changes to BioSequences that I find useful when developing Kmers

TODO:

  • Bump version
  • Add downstream Kmers.jl unit tests

@codecov
Copy link

codecov bot commented Jul 23, 2023

Codecov Report

Attention: Patch coverage is 18.51852% with 22 lines in your changes missing coverage. Please review.

Project coverage is 89.55%. Comparing base (95d9218) to head (c334880).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
src/bit-manipulation/bit-manipulation.jl 26.66% 11 Missing ⚠️
src/alphabet.jl 0.00% 7 Missing ⚠️
src/biosequence/biosequence.jl 33.33% 2 Missing ⚠️
src/biosequence/indexing.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #282      +/-   ##
==========================================
- Coverage   90.87%   89.55%   -1.32%     
==========================================
  Files          31       30       -1     
  Lines        2400     2547     +147     
==========================================
+ Hits         2181     2281     +100     
- Misses        219      266      +47     
Flag Coverage Δ
unittests 89.55% <18.51%> (-1.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TransGirlCodes
Copy link
Member

Heya @jakobnissen where did progress with this get to? Is there anything I can do to help out?

@jakobnissen
Copy link
Member Author

Hey @TransGirlCodes !

I'm working on it on/off as other hobbies and work allows. I won't have time to finish it until early next year.
Do you need Kmers.jl working soon?
Unfortunately, I think I'm still in the early phase of hammering out a candidate 1.0 of Kmers.jl, which means a lot of iteration, and that makes it hard to cooperate. Once a candidate has landed, then the work can be more decentrlaized as tonnes of small things may need changes.

@jakobnissen jakobnissen force-pushed the kmers_compat branch 2 times, most recently from 77f313c to fa55ab3 Compare December 30, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants