Fixing #1299

Proper error handling on lsp version retrival
without it the lsp couldn't be started even when an executable was already existing

CHANGELOG.md

@@ -4,6 +4,7 @@ Changes to Calva.
 
 ## [Unreleased]
 - [Add custom commands from libraries](https://github.com/BetterThanTomorrow/calva/pull/1442)
+- [Clojure-lsp not starting when offline](https://github.com/BetterThanTomorrow/calva/issues/1299)
 - Workaround: [VS Code highlights characters in the output/REPL window prompt](https://github.com/BetterThanTomorrow/calva/pull/1475)
 
 ## [2.0.234] - 2022-01-16

src/lsp/download.ts

@@ -7,9 +7,14 @@ import { https } from 'follow-redirects';
 import * as extractZip from 'extract-zip';
 
 async function getLatestVersion(): Promise<string> {
-    const releasesJSON = await util.fetchFromUrl('https://api.github.com/repos/clojure-lsp/clojure-lsp/releases');
-    const releases = JSON.parse(releasesJSON);
-    return releases[0].tag_name;
+    try {
+        const releasesJSON = await util.fetchFromUrl('https://api.github.com/repos/clojure-lsp/clojure-lsp/releases');
+        console.log("loaded latest Json" + releasesJSON);
+        const releases = JSON.parse(releasesJSON);
+        return releases[0].tag_name;
+    } catch (err) {
+        return "";
+    }
 }
 
 function getZipFileName(platform: string): string {

src/lsp/main.ts

@@ -383,7 +383,7 @@ async function activate(context: vscode.ExtensionContext, handler: TestTreeHandl
     if (userConfiguredClojureLspPath === '') {
         const configuredVersion: string = config.getConfig().clojureLspVersion;
         const downloadVersion = ['', 'latest'].includes(configuredVersion) ? await getLatestVersion() : configuredVersion;
-        if (currentVersion !== downloadVersion) {
+        if (currentVersion !== downloadVersion && downloadVersion !== '') {
             const downloadPromise = downloadClojureLsp(context.extensionPath, downloadVersion);
             lspStatus.text = '$(sync~spin) Downloading clojure-lsp';
             lspStatus.show();