-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Scotland Yard] Some fixes. #38
Open
Zandor300
wants to merge
54
commits into
BertHeesakkers:master
Choose a base branch
from
Zandor300:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… options that will be sent.
…of the required amount. This is to fix a bug that will arise when we start to allow a variable amount of players to join a Scotland Yard game in the future.
Zandor300
changed the title
[Scotland Yard] Some fixes.
[DO NOT MERGE] [Scotland Yard] Some fixes.
Apr 8, 2018
…because it was broken.
Zandor300
changed the title
[DO NOT MERGE] [Scotland Yard] Some fixes.
[Scotland Yard] Some fixes.
Apr 8, 2018
…form them of the new player whose turn it is.
Zandor300
changed the title
[Scotland Yard] Some fixes.
[DO NOT MERGE] [Scotland Yard] Some fixes.
Apr 9, 2018
Zandor300
changed the title
[DO NOT MERGE] [Scotland Yard] Some fixes.
[Scotland Yard] Some fixes.
Apr 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/BertHeesakkers/IGADPiGameServer/pull/38/files or below to see what is changed.
Changes
EMessage_RecvGetPlayerLocations
DATA_1: uint32_t(<NUMBER OF PLAYERS>)
.const uint32_t numPlayers
uses the actual amount of players in the game instead of the required amount to avoid bugs that may arise in the future.EMessage_RecvGetLocation
DATA_1: ClientID(<CLIENT ID>)
.EMessage_RecvGetRemainingTokens
AMOUNT OF TRAVELOPTIONS
is fixed to 3 for detectives and 4 for spies.