Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SoapClient] Added ability to add cURL options later #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

timonf
Copy link

@timonf timonf commented Feb 3, 2015

It's very hard to implement those cURL constants and options into the existing client.builder service. It would be much easier to inject parameters later.

// example code
$this->client = $builder->build(); // $builder from DIC "besimple.soap.client.builder"
$this->client->setRequestOption(CURLOPT_SSL_VERIFYHOST, 0);
$this->client->setRequestOption(CURLOPT_SSL_VERIFYPEER, 0);
$response = $this->client->__soapCall($functionName, $arguments);

So I've added setRequestOption method to SoapClient.

@francisbesset francisbesset force-pushed the master branch 6 times, most recently from 9ed8639 to 27ebf0f Compare June 1, 2015 14:05
@delatbabel
Copy link

LGTM. I need to set the CURL options: CURLOPT_SSL_VERIFYPEER, CURLOPT_SSLCERT, CURLOPT_SSLKEY, and a few others. It appears to me that it's impossible to use the BeSimple SOAP client if I need to set any non-standard SOAP options without this PR being merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants