-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #94 Throws a RouteNotFoundException is a match is found where t… #95
Open
bartmcleod
wants to merge
9
commits into
BeSimple:master
Choose a base branch
from
bartmcleod:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he matched locale from the prefix is different from that in the postfix
Do not merge this yet, there are two problems with the solution, that need to be addresses first:
|
…s matched first and wins
… matching (the locale postfix should agree with the matched locale prefix)
Now the tests are there and the logic has been moved to the inflector, where it belongs. Also, the infix introduced has been moved to a class constant. |
…ay cause the locale parameter will be lost, in which case, strict checking is impossible
… compatible with what we had before strict matching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throws a RouteNotFoundException when a match is found where the matched locale from the prefix is different from that in the postfix.