Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add partial data handling (ie. Progressive JPEG) #478

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

glemartret
Copy link

@glemartret glemartret commented Dec 20, 2024

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

This PR Introduces Progressive JPEG loading and prepare the handling of other "progressive" formats

⤵️ What is the current behavior?

This package don't provide partial data during the download, therefore it's impossible to use partial data for compatible files

🆕 What is the new behavior (if this is a feature change)?

I added a new FileResponse type that extends DownloadProgress but contains usable partial data in it

💥 Does this PR introduce a breaking change?

None

🐛 Recommendations for testing

📝 Links to relevant issues/docs

Issue #43 in flutter_cached_network_image

🤔 Checklist before submitting

  • Check memory efficiency
  • Write tests for the feature
  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated
  • Rebased onto current

PS: This is my first try at publicly contributing to a repo, any feedback would be appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant