Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: remote notifications #527

Merged
merged 22 commits into from
Aug 11, 2024
Merged

Feat: remote notifications #527

merged 22 commits into from
Aug 11, 2024

Conversation

Becca-Saka
Copy link
Contributor

Triggering remote notification from backend -> #503

@Becca-Saka
fix: error on google sign in
2f2f663
@Becca-Saka
feat: backend notification and cron
387210b
@Becca-Saka
Merge branch 'main' of https://github.com/BasedHardware/Friend
cf4728d
@Becca-Saka
Merge branch 'main' of https://github.com/BasedHardware/Friend
623f600
@Becca-Saka
Merge branch 'main' of https://github.com/Becca-Saka/Friend
f979f3a
@Becca-Saka
feat: save notification token
9353394
@Becca-Saka
feat: merged notification class
c63ed56
@Becca-Saka
feat: register notification
0cc4043
@Becca-Saka
fix: notification on startup
155da1e
@Becca-Saka
fix: lint
66d8b72
@Becca-Saka
fix: text length
e07391a
@Becca-Saka
Merge branch 'main' of https://github.com/BasedHardware/Friend
e52edfb
@Becca-Saka
feat: switched db from redis to firestore
94faa9f
@Becca-Saka
Merge branch 'main' of https://github.com/BasedHardware/Friend
580dc90
@Becca-Saka
feta: trigger notifications from realtime plugins
c537652
@Becca-Saka
fix: real time notification flow
6a9768f
@Becca-Saka
Merge branch 'main' of https://github.com/BasedHardware/Friend
c52da38
@Becca-Saka Becca-Saka marked this pull request as ready for review August 9, 2024 04:35
josancamon19
josancamon19 requested changes Aug 9, 2024
View reviewed changes
app/pubspec.yaml Outdated Show resolved Hide resolved
backend/database/notification.py Outdated Show resolved Hide resolved
backend/routers/notifications.py Outdated Show resolved Hide resolved
backend/utils/crons/notification.py Outdated Show resolved Hide resolved
backend/utils/stt/vad.py Outdated Show resolved Hide resolved
@josancamon19
Copy link
Contributor

@Becca-Saka can you also share a video of this implementation working with any of the realtime integrations available?

josancamon19
josancamon19 requested changes Aug 9, 2024
View reviewed changes
backend/routers/notifications.py Outdated Show resolved Hide resolved
@Becca-Saka
Copy link
Contributor Author

Hey @josancamon19, I made the fixes and here is the video.

video.mov

josancamon19
josancamon19 approved these changes Aug 11, 2024
View reviewed changes
Copy link
Contributor

@josancamon19 josancamon19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes required, I'll do them. and follow up if there's a bigger change

@josancamon19 josancamon19 merged commit 6a7f01e into BasedHardware:main Aug 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josancamon19 josancamon19 josancamon19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Becca-Saka @josancamon19