Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): dialog (#7) #8

Merged
merged 1 commit into from
Jan 30, 2024
Merged

feat(common): dialog (#7) #8

merged 1 commit into from
Jan 30, 2024

Conversation

kyechan99
Copy link
Member

common ui

  • Dialog

feature

  • Dialog
  • DialogToggle
  • DialogContent
  • DialogHeader
  • DialogFooter
  • DialogClose
  • DialogTitle
  • DialogDescription

@kyechan99 kyechan99 added the feature New feature or request label Jan 30, 2024
@kyechan99 kyechan99 added this to the Common UI milestone Jan 30, 2024
@kyechan99 kyechan99 self-assigned this Jan 30, 2024
@kyechan99 kyechan99 linked an issue Jan 30, 2024 that may be closed by this pull request
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 80.08% 1086 / 1356
🔵 Statements 80.08% 1086 / 1356
🔵 Functions 58.92% 33 / 56
🔵 Branches 75% 69 / 92
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/Slot.tsx 76% 60% 100% 76% 17-23, 40-41, 43, 45-46
src/components/common/index.ts 100% 100% 100% 100%
src/components/common/Dialog/Dialog.tsx 100% 100% 100% 100%
src/components/common/Dialog/DialogClose.tsx 100% 66.66% 100% 100%
src/components/common/Dialog/DialogContent.tsx 98.63% 71.42% 50% 98.63% 36-37
src/components/common/Dialog/DialogContext.tsx 100% 100% 100% 100%
src/components/common/Dialog/DialogToggle.tsx 100% 66.66% 100% 100%
src/components/common/Dialog/index.tsx 100% 100% 100% 100%
src/hooks/useContext.ts 84.61% 50% 100% 84.61% 7-8
Generated in workflow #14

@codecov-commenter
Copy link

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (bf420a6) 74.40% compared to head (e2a8c45) 80.08%.

Files Patch % Lines
src/components/Slot.tsx 76.00% 12 Missing ⚠️
src/components/common/Dialog/DialogContent.tsx 98.63% 2 Missing ⚠️
src/hooks/useContext.ts 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   74.40%   80.08%   +5.68%     
==========================================
  Files          25       33       +8     
  Lines        1043     1356     +313     
  Branches       57       84      +27     
==========================================
+ Hits          776     1086     +310     
- Misses        267      270       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyechan99 kyechan99 merged commit 7545426 into main Jan 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: dialog
2 participants