Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): badge (#3) #4

Merged
merged 1 commit into from
Jan 29, 2024
Merged

feat(common): badge (#3) #4

merged 1 commit into from
Jan 29, 2024

Conversation

kyechan99
Copy link
Member

common ui

  • Badge

feature

  • variant
  • size

@kyechan99 kyechan99 added the feature New feature or request label Jan 29, 2024
@kyechan99 kyechan99 self-assigned this Jan 29, 2024
@kyechan99 kyechan99 linked an issue Jan 29, 2024 that may be closed by this pull request
@kyechan99 kyechan99 added this to the Common UI milestone Jan 29, 2024
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 83.07% 687 / 827
🔵 Statements 83.07% 687 / 827
🔵 Functions 62.79% 27 / 43
🔵 Branches 72.58% 45 / 62
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/common/index.ts 100% 100% 100% 100%
src/components/common/Badge/index.tsx 43.01% 100% 0% 43.01% 10-44, 47-62, 92-93
src/components/common/Button/index.tsx 68.75% 38.88% 100% 68.75% 12-14, 16-19, 21-24, 26-32, 34-36, 49-51, 57-63, 66-68, 90-91, 96-99
src/styles/theme.ts 100% 100% 100% 100%
Generated in workflow #10

@codecov-commenter
Copy link

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (84ba46a) 88.11% compared to head (cefc94c) 83.07%.

Files Patch % Lines
src/components/common/Badge/index.tsx 43.01% 53 Missing ⚠️
src/components/common/Button/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
- Coverage   88.11%   83.07%   -5.05%     
==========================================
  Files          22       23       +1     
  Lines         732      827      +95     
  Branches       56       56              
==========================================
+ Hits          645      687      +42     
- Misses         87      140      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyechan99 kyechan99 merged commit e59a264 into main Jan 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: badge
2 participants