Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RNTA + CI #642

Merged
merged 65 commits into from
May 24, 2024
Merged

RNTA + CI #642

merged 65 commits into from
May 24, 2024

Conversation

CedricGuillemet
Copy link
Contributor

@CedricGuillemet CedricGuillemet commented Mar 19, 2024 •
edited
Loading

Transition PR to have legacy and RNTA playground to build. Nextg PRs will focus on replacing/removing legacy.

  • Added PR steps to build RNTA for ios, android and Windows
  • Xcode15 / babylon.js version. Duplicate from Update BN #645
  • CMake and vcxproj update to support BRNPlayground and legacy PG

kelset and others added 30 commits February 19, 2024 12:32
@kelset
baseline: adding RNTA vanilla, it works
58239cb
@kelset
wire in the babylon stuff
3bb2aef
@kelset
a couple of temp files
b58c768
@kelset
minor cleanup, bump to latest 73 and RNTA
3988686
@kelset
add a quick readme
c824eac
@kelset @tido64
Update Apps/BRNPlayground/macos/Podfile
e86b82d 
Co-authored-by: Tommy Nguyen <[email protected]>
@kelset @tido64
Update Apps/BRNPlayground/postinstall.js
f1e5968 
Co-authored-by: Tommy Nguyen <[email protected]>
@kelset @tido64
Update Apps/BRNPlayground/.gitignore
464a420 
Co-authored-by: Tommy Nguyen <[email protected]>
@kelset
get CMake to build
7462da3
@kelset
add xcworkspace
03b5a33
@kelset
bump to latest RN and RNTA
03016e9
@CedricGuillemet
RNTA + CI
d7c79f8
@CedricGuillemet
npm install
7c2b55a
@CedricGuillemet
java 17 instead of 21(default) because of this issue:
c06531b 
 jdk.tools.jlink.plugin.PluginException: ModuleTarget is malformed: platformString missing delimiter: android
@CedricGuillemet
Windows build
c68eab1
@CedricGuillemet
npm install package
eb617b3
@CedricGuillemet
msbuild typo
f72869d
@CedricGuillemet
more windows build steps
e3742e2
@CedricGuillemet
build steps in CI
54d07da
@CedricGuillemet
path typo
1d99c24
@CedricGuillemet
nuget restore
34e5aa4
@CedricGuillemet
BN build
bf2b8d3
@CedricGuillemet
vcxproj paths
2169ffa
@CedricGuillemet
x86
de4b8f7
@CedricGuillemet
back to x64
f9d8bfe
@CedricGuillemet
test w/o --use-nuget
55918a9
@CedricGuillemet
patch rnpermissions vcxproj
1abe08c
@CedricGuillemet
back with use-nuget
06c8d09
@CedricGuillemet
permissions vcxproj
9b6a02a
@CedricGuillemet
vcxproj
9b4c7d9
@CedricGuillemet CedricGuillemet mentioned this pull request Mar 29, 2024
Merged
@matthargett
Copy link

Any updates on this? Looks like CI started passing with the last commit.

@CedricGuillemet
Copy link
Contributor Author

Any updates on this? Looks like CI started passing with the last commit.

I'll get back working on this in the coming days.

@CedricGuillemet CedricGuillemet marked this pull request as ready for review May 23, 2024 16:33
@CedricGuillemet CedricGuillemet merged commit 949bbe1 into BabylonJS:master May 24, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantrem ryantrem ryantrem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CedricGuillemet @matthargett @ryantrem @kelset