Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #66

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Improvements #66

wants to merge 27 commits into from

Conversation

joamatab
Copy link

  • better name for pins (defined repr)
  • clean code with sourcery
  • add r to docstrings

@AustP
Copy link
Contributor

AustP commented May 20, 2022

Thanks @joamatab these changes look good. Our CI/CD is still having issues but @SkandanC thinks he can resolve them on Monday. After that, I'll run CI/CD on this and if it passes, we'll get it merged in.

@joamatab
Copy link
Author

Any updates on this? Can you make a new release?

@SkandanC SkandanC self-requested a review October 27, 2022 00:36
@SkandanC
Copy link
Contributor

CI/CD fixed in #79

This reverts commit 35739af, reversing
changes made to e07d61a.
@SkandanC
Copy link
Contributor

@joamatab, could you merge simphony's master branch into yours, after that it should pass all checks and I will merge it in.

Thanks again for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants