Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non functional tests #31

Merged
merged 3 commits into from
May 22, 2024
Merged

Non functional tests #31

merged 3 commits into from
May 22, 2024

Conversation

Posfay
Copy link
Contributor

@Posfay Posfay commented May 22, 2024

Closing #21

@Posfay Posfay requested a review from n0F4x-player May 22, 2024 17:27
n0F4x-player
n0F4x-player reviewed May 22, 2024
View reviewed changes
Copy link
Contributor

@n0F4x-player n0F4x-player left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly don't understand the benefit of the rewritten code.

doc/Non_functional_tests.adoc Show resolved Hide resolved
src/macaroni/app/App.java Show resolved Hide resolved
src/macaroni/app/App.java Show resolved Hide resolved
@Posfay
Copy link
Contributor Author

Posfay commented May 22, 2024

I honestly don't understand the benefit of the rewritten code.

The performance improvement comes from reordering the timing calculations so that it matches the 60 fps more accurately than before (usually >60 fps)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Posfay Posfay merged commit 58dbd95 into main May 22, 2024
4 checks passed
@Posfay Posfay linked an issue May 22, 2024 that may be closed by this pull request
Non-functional tests #21
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n0F4x-player n0F4x-player n0F4x-player approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-functional tests
2 participants
@Posfay @n0F4x-player