Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual and sonarcloud review #6

Merged
merged 6 commits into from
May 19, 2024
Merged

Conversation

ErikSkare
Copy link
Contributor

Test coverage passing is not required here. Tests will be implemented in issue #2.

Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)
3.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Contributor

@wittmajerd wittmajerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Átnéztem és mindent rendben találtam, annyi még hogy egy rövid feladat dokumentációt írj még a doc mappába

Copy link
Contributor

@Peter200204 Peter200204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rendben van.

Copy link
Contributor

@tanaiadam tanaiadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Új sort tegyél a fájlok végére (dockerfile, gitignore stb.)
Kompatibilitás szempontból előnyös.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mehetett volna bele az *.idea is.

@tanaiadam tanaiadam self-requested a review May 19, 2024 16:59
@ErikSkare ErikSkare merged commit 179db39 into main May 19, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants