Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup build and ci #3

Merged
merged 3 commits into from
May 19, 2024
Merged

Setup build and ci #3

merged 3 commits into from
May 19, 2024

Conversation

ErikSkare
Copy link
Contributor

@ErikSkare ErikSkare commented May 14, 2024 •
edited
Loading

Test coverage passing is not required here. Tests will be implemented in issue #2.

@ErikSkare ErikSkare requested a review from Peter200204 May 14, 2024 19:13
@ErikSkare ErikSkare requested review from tanaiadam and wittmajerd May 16, 2024 15:19
@ErikSkare ErikSkare force-pushed the setup-build-and-ci branch from f4b5640 to 6b7bc76 Compare May 16, 2024 16:00
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

tanaiadam
tanaiadam approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@tanaiadam tanaiadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 random security hotspotot ki lehetne kapcsolni nem?

@ErikSkare ErikSkare merged commit 081611f into main May 19, 2024
2 of 3 checks passed
@ErikSkare ErikSkare self-assigned this May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Peter200204 Peter200204 Peter200204 approved these changes

@wittmajerd wittmajerd wittmajerd approved these changes

@tanaiadam tanaiadam tanaiadam approved these changes

Assignees

@ErikSkare ErikSkare

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ErikSkare @tanaiadam @wittmajerd @Peter200204 @Jona-G