Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed Sonarlint issues #15

Merged
merged 1 commit into from
May 21, 2024
Merged

fixed Sonarlint issues #15

merged 1 commit into from
May 21, 2024

Conversation

Hadeszka
Copy link
Contributor

Fixed the majority of SonarLint issues

@Hadeszka Hadeszka requested a review from PencMark May 21, 2024 17:16
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
6.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

PencMark
PencMark approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@PencMark PencMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jó javítások, sokkal átláthatóbb és letisztultabb lett tőle a kód.

@Hadeszka Hadeszka merged commit a69795f into main May 21, 2024
2 of 3 checks passed
@Hadeszka Hadeszka deleted the FixedSonarLintIssues branch May 21, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PencMark PencMark PencMark approved these changes

Assignees

@PencMark PencMark

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hadeszka @PencMark