Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonarcloud main issues fix #15

Merged
merged 19 commits into from
May 22, 2024
Merged

Sonarcloud main issues fix #15

merged 19 commits into from
May 22, 2024

Conversation

Abri02
Copy link
Contributor

@Abri02 Abri02 commented May 19, 2024

No description provided.

@Abri02 Abri02 linked an issue May 19, 2024 that may be closed by this pull request
Duhi95 added 2 commits May 20, 2024 00:47
Accidentally, the Random generator got into the new code, Because of the 2 separate branch merge conflict reviews i did.
@Duhi95 Duhi95 assigned Duhi95 and unassigned Duhi95 May 19, 2024
Copy link

sonarcloud bot commented May 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@Duhi95
Copy link
Contributor

Duhi95 commented May 22, 2024

Good job!

@Duhi95 Duhi95 merged commit e243b95 into main May 22, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix important issues found by SonarCloud
3 participants