Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8 create UI tests and add to ci pipeline #13

Merged
merged 8 commits into from
May 21, 2024

Conversation

gerencsermate
Copy link
Contributor

I added cucumber to the project.

Additionally implemented a few BDD test using the Cucumber java framework.

@gerencsermate gerencsermate requested a review from sutheo17 May 20, 2024 18:38
@gerencsermate gerencsermate linked an issue May 20, 2024 that may be closed by this pull request
@gerencsermate
Copy link
Contributor Author

I tested some more complex game scenarios with Cucumber.

The focus was on testing the movement of the saboteur and the mechanic when they meet on the pipe system.
Furthermore I tested pipe detaching.

@gerencsermate
Copy link
Contributor Author

I wrote a short summary of the testing.

Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding Test Coverage to the pipeline.

Copy link
Contributor

@sutheo17 sutheo17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests seem to be running fine on my end. And the pipeline recognise them well fine.

@sutheo17 sutheo17 merged commit cfd32c6 into main May 21, 2024
1 of 2 checks passed
@sutheo17 sutheo17 added the enhancement New feature or request label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create BDD tests and add to CI pipeline
2 participants