Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry_Engine: IsRigidTransformation bug fixed #3356

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

pawelbaran
Copy link
Member

@pawelbaran pawelbaran commented Jun 11, 2024

Issues addressed by this PR

Closes #3355

Test files

On SharePoint - also includes generation of UTs

Changelog

Additional comments

@pawelbaran pawelbaran added the type:bug Error or unexpected behaviour label Jun 11, 2024
@pawelbaran pawelbaran self-assigned this Jun 11, 2024
@pawelbaran
Copy link
Member Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Jun 11, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@pawelbaran
Copy link
Member Author

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Jun 11, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check unit-tests

There are 27 requests in the queue ahead of you.

@pawelbaran
Copy link
Member Author

Following the discussion with @IsakNaslundBh, we are parking this PR until the new milestone:

  • the fix in this PR is correct by itself
  • the methods consuming IsRigidTransformation are not ready for the change because a few Transform methods do not support reflection (e.g. the one against BH.oM.Structures.Elements.Bar would require mirroring the profile, similar to Beam and possible a few others)

To be picked up in 7.3 by tweaking individual Transform methods where needed.

@pawelbaran pawelbaran added the status:parked PR on hold, requiring further discussion or planning label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:parked PR on hold, requiring further discussion or planning type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geometry_Engine: IsRigidTransformation query returns false for reflection
1 participant