-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MSAL's Newton.Json version to 13.0.1 #3521
Conversation
Updating namespace Applying Unity fixes Applying Netstandard 2 fix Applying UAP fix Setting C3 lang version to latest
suppressing warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to include non-code files like .snk, .csproj, pics, etc?
Not sure if there is any benefit for including those, since we're building the source code as part of MSAL. |
Exactly. But they ARE included in this PR (I'd remove them) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applying Unity fixes
Applying Netstandard 2 fix
Applying UAP fix
- Can you specify what/where are the above specific changes? (Is it just a few flags?)
- Maybe helpful to add a Readme in the top
json
folder with what the version of this Json.Net code is. - Are there any breaking changes in 13.x that affect us?
src/client/Microsoft.Identity.Client/json/Newtonsoft.Json.csproj
Outdated
Show resolved
Hide resolved
The Unity fix in particular should ideally be re-applied as a separate commit. It will help us track it down in the future. |
|
The net standard and UAP fixes are just flags. since the fixes are the same as we have in the main branch, they do not show in the diff and nuget wont let me comment on the lines where the are. Added readme no breaking changes that I have seen so far. They are not mentioned in the Release Notes |
# Conflicts: # src/client/Microsoft.Identity.Client/json/.editorconfig
* Applying Unity fixes to new Newtonsoft.JSON * Making newtonsoft classes internal * Add read me Cleaned up unused files * More classes moved to internal Co-authored-by: trwalke <[email protected]>
Fixes #
#3413
Changes proposed in this request
Updating newtonsoft.Json to 13.0.1.
Updating namespace
Applying Unity fixes
Applying Netstandard 2 fix
Applying UAP fix
Setting C# lang version to
latest
Testing
Unity test app
Performance impact
Documentation