Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iccpd - remove unused function #272

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

maipbui
Copy link
Member

@maipbui maipbui commented Feb 29, 2024

ADO 27008034

Why I did it

set_route_by_linux_route() is not called by any function within this repo and its submodules, checked on 202106 branch and master branch

git grep --recurse-submodules "set_route_by_linux_route"
src/iccpd/src/mlacp_link_handler.c:static void set_route_by_linux_route(struct CSM* csm,
src/iccpd/src/mlacp_link_handler.c:            /*set_route_by_linux_route(csm, set_l3_local_if, 1);*/   /*add static route by linux route tool*/
src/iccpd/src/mlacp_link_handler.c:            /*set_route_by_linux_route(csm, set_l3_local_if, 0);*/    /*del static route by linux route tool*/

How I did it

Remove unused function set_route_by_linux_route()

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202305

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@maipbui maipbui requested a review from qiluo-msft February 29, 2024 20:38
@maipbui maipbui requested a review from lguohan as a code owner February 29, 2024 20:38
@maipbui maipbui marked this pull request as draft February 29, 2024 21:08
@qiluo-msft qiluo-msft requested a review from rlhui March 5, 2024 18:22
@maipbui maipbui marked this pull request as ready for review March 8, 2024 19:50
@maipbui
Copy link
Member Author

maipbui commented Mar 11, 2024

@gechiang Can we merge this PR? looks like there's no code sync from sonic-net repo.

@gechiang gechiang merged commit 6bfb85a into Azure:master Mar 15, 2024
3 checks passed
@maipbui maipbui deleted the remove_unused_func branch March 15, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants