Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chat] Fixed the issue where chat message bubble has an incorrect margin in editing state #4832

Merged
merged 8 commits into from
Jul 11, 2024
Merged

[Chat] Fixed the issue where chat message bubble has an incorrect margin in editing state #4832

merged 8 commits into from
Jul 11, 2024

Conversation

jpeng-ms
Copy link
Member

@jpeng-ms jpeng-ms commented Jul 9, 2024 •
edited
Loading

What

before after
image image
image image

Why

How Tested

  1. use the storybook link from CI
  2. go to message thread > preview > send a message with attachment
  3. click on edit
  4. check the layout

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@jpeng-ms jpeng-ms added the update_snapshots Set this label to request automated update of UI snapshots label Jul 9, 2024
@github-actions github-actions bot removed the update_snapshots Set this label to request automated update of UI snapshots label Jul 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

CallWithChat bundle size is increased❗.

  • Current size: 6451204
  • Base size: 6451119
  • Diff size: 85

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

Chat bundle size is increased❗.

  • Current size: 2117539
  • Base size: 2117454
  • Diff size: 85

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Storybook URL https://60c7ae6891f0e90039d7cd54-kftoeizarz.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

Calling bundle size is not changed.

  • Current size: 5074065
  • Base size: 5074065
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 52331 / 84431
61.98%		 52331 / 84431
61.98%		 1060 / 2364
44.83%		 2928 / 5018
58.34%
Current 52359 / 84437
62%		 52359 / 84437
62%		 1060 / 2364
44.83%		 2938 / 5024
58.47%
Diff 28 / 6
0.02%		 28 / 6
0.02%		 0 / 0
0%		 10 / 6
0.13%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 26563 / 41758
63.61%		 26563 / 41758
63.61%		 720 / 1298
55.46%		 2100 / 3344
62.79%
Current 26569 / 41764
63.61%		 26569 / 41764
63.61%		 720 / 1298
55.46%		 2100 / 3344
62.79%
Diff 6 / 6
0%		 6 / 6
0%		 0 / 0
0%		 0 / 0
0%

@jpeng-ms jpeng-ms added the update_snapshots Set this label to request automated update of UI snapshots label Jul 9, 2024
@github-actions github-actions bot removed the update_snapshots Set this label to request automated update of UI snapshots label Jul 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-bswsqhieei.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-wsmvduvtac.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-znobvlebcx.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-nuuhkqzoan.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-conselfwln.chromatic.com/

@jpeng-ms jpeng-ms changed the title [WIP] [Chat] Fixed the issue where chat message bubble has an incorrect margin in editing state Jul 9, 2024
@jpeng-ms jpeng-ms marked this pull request as ready for review July 9, 2024 22:10
@jpeng-ms jpeng-ms requested review from a team as code owners July 9, 2024 22:10
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-bwntzqlbxj.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-wrtcpwovus.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-hufpyoushs.chromatic.com/

@jpeng-ms jpeng-ms enabled auto-merge (squash) July 9, 2024 23:32
@github-actions GitHub Actions
Copy link
Contributor

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-odejprwtmo.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-aoqiuxbeso.chromatic.com/

@jpeng-ms jpeng-ms merged commit 8579fb6 into main Jul 11, 2024
43 checks passed
@jpeng-ms jpeng-ms deleted the john/edit-box-bug branch July 11, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaLai JoshuaLai JoshuaLai approved these changes

@vhuseinova-msft vhuseinova-msft vhuseinova-msft approved these changes

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@dmceachernmsft dmceachernmsft Awaiting requested review from dmceachernmsft dmceachernmsft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@PorterNan PorterNan Awaiting requested review from PorterNan PorterNan is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@AmyL219 AmyL219 Awaiting requested review from AmyL219 AmyL219 is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@JoshuaLai JoshuaLai

@palatter palatter

@vhuseinova-msft vhuseinova-msft

@Leah-Xia-Microsoft Leah-Xia-Microsoft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jpeng-ms @JoshuaLai @vhuseinova-msft @palatter @Leah-Xia-Microsoft