Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pipeline] Introduce new publish chromatic #4828

Merged
merged 13 commits into from
Jul 9, 2024
Merged

[Pipeline] Introduce new publish chromatic #4828

merged 13 commits into from
Jul 9, 2024

Conversation

JoshuaLai
Copy link
Member

What

New job to generate changes to storybook8

Why

Generate new url when applicable

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024 •
edited
Loading

Calling bundle size is not changed.

  • Current size: 5072386
  • Base size: 5072386
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024 •
edited
Loading

CallWithChat bundle size is not changed.

  • Current size: 6449093
  • Base size: 6449093
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024 •
edited
Loading

Chat bundle size is not changed.

  • Current size: 2116303
  • Base size: 2116303
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024 •
edited
Loading

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 26550 / 41586
63.84%		 26550 / 41586
63.84%		 720 / 1296
55.55%		 2125 / 3356
63.31%
Current 26550 / 41586
63.84%		 26550 / 41586
63.84%		 720 / 1296
55.55%		 2125 / 3356
63.31%
Diff 0 / 0
0%		 0 / 0
0%		 0 / 0
0%		 0 / 0
0%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024 •
edited
Loading

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 51838 / 84140
61.6%		 51838 / 84140
61.6%		 1041 / 2350
44.29%		 3036 / 4984
60.91%
Current 51758 / 84140
61.51%		 51758 / 84140
61.51%		 1041 / 2350
44.29%		 3016 / 4977
60.59%
Diff -80 / 0
-0.09%		 -80 / 0
-0.09%		 0 / 0
0%		 -20 / -7
-0.32%

@JoshuaLai JoshuaLai marked this pull request as ready for review July 8, 2024 21:51
@JoshuaLai JoshuaLai requested review from a team as code owners July 8, 2024 21:51
@JoshuaLai JoshuaLai marked this pull request as draft July 8, 2024 23:24
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Storybook URL https://60c7ae6891f0e90039d7cd54-jqbudqtxwd.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-uhxnmsgbdc.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-aqhdyykeyr.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-hbvyekxvfl.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-bvxzkiidvn.chromatic.com/

@JoshuaLai JoshuaLai marked this pull request as ready for review July 9, 2024 17:38
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-zfwwundroy.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-zopiprgxlg.chromatic.com/

@JoshuaLai JoshuaLai merged commit 8ec2192 into main Jul 9, 2024
43 checks passed
@JoshuaLai JoshuaLai deleted the storybook/chromaticv8 branch July 9, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlynmac emlynmac emlynmac left review comments

@AmyL219 AmyL219 AmyL219 approved these changes

@prabhjot-msft prabhjot-msft prabhjot-msft approved these changes

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@dmceachernmsft dmceachernmsft Awaiting requested review from dmceachernmsft dmceachernmsft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@PorterNan PorterNan Awaiting requested review from PorterNan PorterNan is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@AmyL219 AmyL219

@prabhjot-msft prabhjot-msft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JoshuaLai @emlynmac @AmyL219 @prabhjot-msft