Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RTE] Add tests for Rich Text Editor #4813

Merged
merged 20 commits into from
Jul 9, 2024
Merged

[RTE] Add tests for Rich Text Editor #4813

merged 20 commits into from
Jul 9, 2024

Conversation

palatter
Copy link
Member

@palatter palatter commented Jul 3, 2024

What

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024 •
edited
Loading

Calling bundle size is not changed.

  • Current size: 5073105
  • Base size: 5073105
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024 •
edited
Loading

CallWithChat bundle size is not changed.

  • Current size: 6449812
  • Base size: 6449812
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024 •
edited
Loading

Chat bundle size is not changed.

  • Current size: 2116619
  • Base size: 2116619
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024

Storybook URL https://60c7ae6891f0e90039d7cd54-jdwkbgrcup.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Storybook URL https://60c7ae6891f0e90039d7cd54-pbonotyhlz.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Storybook URL https://60c7ae6891f0e90039d7cd54-rjixikqpzd.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024

Storybook URL https://60c7ae6891f0e90039d7cd54-vemvmojvdq.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024

Storybook URL https://60c7ae6891f0e90039d7cd54-ulwzybrsvq.chromatic.com/

@palatter palatter changed the title [DRAFT][RTE] Add tests for Rich Text Editor [RTE] Add tests for Rich Text Editor Jul 5, 2024
@palatter palatter assigned palatter and unassigned palatter Jul 5, 2024
@palatter palatter marked this pull request as ready for review July 5, 2024 20:51
@palatter palatter requested review from a team as code owners July 5, 2024 20:51
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024

Storybook URL https://60c7ae6891f0e90039d7cd54-uomywsynam.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024

Storybook URL https://60c7ae6891f0e90039d7cd54-ijvqnnavhs.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Storybook URL https://60c7ae6891f0e90039d7cd54-hanqossfjf.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024 •
edited
Loading

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 51800 / 84187
61.52%		 51800 / 84187
61.52%		 1041 / 2350
44.29%		 3052 / 4997
61.07%
Current 52255 / 84190
62.06%		 52255 / 84190
62.06%		 1058 / 2360
44.83%		 2921 / 5005
58.36%
Diff 455 / 3
0.54%		 455 / 3
0.54%		 17 / 10
0.54%		 -131 / 8
-2.71%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Storybook URL https://60c7ae6891f0e90039d7cd54-npegbismkd.chromatic.com/

@palatter palatter added the does not need changelog Changes that does not affect the published package in any way do not need changelog entry label Jul 8, 2024
@palatter palatter closed this Jul 8, 2024
@palatter palatter reopened this Jul 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Storybook URL https://60c7ae6891f0e90039d7cd54-zydzpyfaep.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Storybook URL https://60c7ae6891f0e90039d7cd54-ksuazkltmp.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Storybook URL https://60c7ae6891f0e90039d7cd54-zjqjxmbyjg.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 26617 / 41598
63.98%		 26617 / 41598
63.98%		 720 / 1296
55.55%		 2115 / 3356
63.02%
Current 26565 / 41602
63.85%		 26565 / 41602
63.85%		 720 / 1296
55.55%		 2120 / 3354
63.2%
Diff -52 / 4
-0.13%		 -52 / 4
-0.13%		 0 / 0
0%		 5 / -2
0.18%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-nflthifmmf.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-wjajtshpcd.chromatic.com/

@palatter palatter merged commit 25ffe01 into main Jul 9, 2024
42 checks passed
@palatter palatter deleted the palatter/rte-unit-tests branch July 9, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vhuseinova-msft vhuseinova-msft vhuseinova-msft approved these changes

@Leah-Xia-Microsoft Leah-Xia-Microsoft Leah-Xia-Microsoft approved these changes

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@dmceachernmsft dmceachernmsft Awaiting requested review from dmceachernmsft dmceachernmsft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@PorterNan PorterNan Awaiting requested review from PorterNan PorterNan is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@AmyL219 AmyL219 Awaiting requested review from AmyL219 AmyL219 is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees
No one assigned
Labels
does not need changelog Changes that does not affect the published package in any way do not need changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@palatter @vhuseinova-msft @Leah-Xia-Microsoft