Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add storybook documentation for rich text editor in composites and onPaste callback for components #4806

Closed
wants to merge 9 commits into from
Closed

Add storybook documentation for rich text editor in composites and onPaste callback for components #4806

wants to merge 9 commits into from

Conversation

vhuseinova-msft
Copy link
Member

What

  • updated storybook documentation.
  • Please note that inlineImages functionality will be covered in a separate task and PR

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@vhuseinova-msft vhuseinova-msft added the does not need changelog Changes that does not affect the published package in any way do not need changelog entry label Jul 2, 2024
@vhuseinova-msft vhuseinova-msft requested review from a team as code owners July 2, 2024 23:27
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024 •
edited
Loading

Calling bundle size is decreased✅.

  • Current size: 5087050
  • Base size: 5087051
  • Diff size: -1

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024 •
edited
Loading

Chat bundle size is decreased✅.

  • Current size: 2109624
  • Base size: 2109977
  • Diff size: -353

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024 •
edited
Loading

CallWithChat bundle size is decreased✅.

  • Current size: 6443792
  • Base size: 6444074
  • Diff size: -282

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024

Storybook URL https://60c7ae6891f0e90039d7cd54-jjhckyarqz.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024 •
edited
Loading

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 52587 / 84626
62.14%		 52587 / 84626
62.14%		 1068 / 2369
45.08%		 3137 / 5134
61.1%
Current 52464 / 84568
62.03%		 52464 / 84568
62.03%		 1067 / 2368
45.05%		 2956 / 5029
58.77%
Diff -123 / -58
-0.11%		 -123 / -58
-0.11%		 -1 / -1
-0.03%		 -181 / -105
-2.33%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024 •
edited
Loading

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 26611 / 42112
63.19%		 26611 / 42112
63.19%		 721 / 1299
55.5%		 2097 / 3341
62.76%
Current 26606 / 42103
63.19%		 26606 / 42103
63.19%		 721 / 1299
55.5%		 2093 / 3338
62.7%
Diff -5 / -9
0%		 -5 / -9
0%		 0 / 0
0%		 -4 / -3
-0.06%

@vhuseinova-msft vhuseinova-msft marked this pull request as draft July 3, 2024 17:24
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Storybook URL https://60c7ae6891f0e90039d7cd54-yzpkwejazu.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Storybook URL https://60c7ae6891f0e90039d7cd54-bsdcdjjahw.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-gohxfmytkt.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-amwlbfzncv.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-cjbxmjhfcu.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-hwmrqjuvjg.chromatic.com/

@JoshuaLai
Copy link
Member

I know this PR is still a WIP, just wanted to call out some of these pages have been migrated to storybook 8 so we should also make the changes over to those files as well so they are not lost

@vhuseinova-msft vhuseinova-msft deleted the vhuseinova/rte-composite-storybook-update branch July 22, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leah-Xia-Microsoft Leah-Xia-Microsoft Leah-Xia-Microsoft left review comments

@AmyL219 AmyL219 Awaiting requested review from AmyL219 AmyL219 is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@dmceachernmsft dmceachernmsft Awaiting requested review from dmceachernmsft dmceachernmsft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@PorterNan PorterNan Awaiting requested review from PorterNan PorterNan is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

Assignees

@palatter palatter

@Leah-Xia-Microsoft Leah-Xia-Microsoft

Labels
does not need changelog Changes that does not affect the published package in any way do not need changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vhuseinova-msft @JoshuaLai @Leah-Xia-Microsoft @palatter