Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pinned participant limit to update when pinned participants are removed from call #4761

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mgamis-msft
Copy link
Contributor

What

Fix pinned participant limit to update when pinned participants are removed from call

Why

https://skype.visualstudio.com/SPOOL/_workitems/edit/3765815

How Tested

2024-06-19.16-22-26.mp4

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

Copy link
Contributor

Copy link
Contributor

github-actions bot commented Jun 19, 2024

CallWithChat bundle size is increased❗.

  • Current size: 6392322
  • Base size: 6392144
  • Diff size: 178

Copy link
Contributor

Chat bundle size is not changed.

  • Current size: 2099307
  • Base size: 2099307
  • Diff size: 0

Copy link
Contributor

github-actions bot commented Jun 19, 2024

Calling bundle size is increased❗.

  • Current size: 5031784
  • Base size: 5031614
  • Diff size: 170

Copy link
Contributor

github-actions bot commented Jun 19, 2024

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 26187 / 41112
63.69%
26187 / 41112
63.69%
715 / 1284
55.68%
2091 / 3314
63.09%
Current 26187 / 41112
63.69%
26187 / 41112
63.69%
715 / 1284
55.68%
2076 / 3304
62.83%
Diff 0 / 0
0%
0 / 0
0%
0 / 0
0%
-15 / -10
-0.26%

Copy link
Contributor

github-actions bot commented Jun 19, 2024

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 51118 / 82635
61.85%
51118 / 82635
61.85%
1037 / 2323
44.64%
3037 / 4944
61.42%
Current 51095 / 82653
61.81%
51095 / 82653
61.81%
1037 / 2323
44.64%
3001 / 4926
60.92%
Diff -23 / 18
-0.04%
-23 / 18
-0.04%
0 / 0
0%
-36 / -18
-0.5%

Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants