-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pinned participant limit to update when pinned participants are removed from call #4761
Open
mgamis-msft
wants to merge
3
commits into
main
Choose a base branch
from
mgamis/fix-pinned-participant-limit-when-pinned-participant-is-removed
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix pinned participant limit to update when pinned participants are removed from call #4761
mgamis-msft
wants to merge
3
commits into
main
from
mgamis/fix-pinned-participant-limit-when-pinned-participant-is-removed
+46
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ants are removed from call
CallWithChat bundle size is increased❗.
|
Chat bundle size is not changed.
|
Calling bundle size is increased❗.
|
@azure/communication-react jest test coverage for stable.
|
@azure/communication-react jest test coverage for beta.
|
…ned-participant-is-removed
dmceachernmsft
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix pinned participant limit to update when pinned participants are removed from call
Why
https://skype.visualstudio.com/SPOOL/_workitems/edit/3765815
How Tested
2024-06-19.16-22-26.mp4
Process & policy checklist
Is this a breaking change?