Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support HMR for codespaces development in our test apps #4567

Merged
merged 9 commits into from
Aug 29, 2024
Merged

Support HMR for codespaces development in our test apps #4567

merged 9 commits into from
Aug 29, 2024

Conversation

JamesBurnside
Copy link
Member

@JamesBurnside JamesBurnside commented May 2, 2024 •
edited
Loading

What

Why

Support hot module reload in our samples (no more refreshing the page, rejoining the call etc. for small changes)

How Tested

@JamesBurnside JamesBurnside added the does not need changelog Changes that does not affect the published package in any way do not need changelog entry label May 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2024 •
edited
Loading

Chat bundle size is decreased✅.

  • Current size: 2109938
  • Base size: 2109939
  • Diff size: -1

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2024 •
edited
Loading

Calling bundle size is not changed.

  • Current size: 8140145
  • Base size: 8140145
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2024 •
edited
Loading

CallWithChat bundle size is not changed.

  • Current size: 8140159
  • Base size: 8140159
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2024 •
edited
Loading

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 26332 / 42240
62.33%		 26332 / 42240
62.33%		 723 / 1309
55.23%		 2085 / 3336
62.5%
Current 26390 / 42240
62.47%		 26390 / 42240
62.47%		 723 / 1309
55.23%		 2097 / 3349
62.61%
Diff 58 / 0
0.14%		 58 / 0
0.14%		 0 / 0
0%		 12 / 13
0.11%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2024 •
edited
Loading

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 53910 / 88163
61.14%		 53910 / 88163
61.14%		 1078 / 2462
43.78%		 3169 / 5239
60.48%
Current 53934 / 88163
61.17%		 53934 / 88163
61.17%		 1078 / 2462
43.78%		 3161 / 5228
60.46%
Diff 24 / 0
0.03%		 24 / 0
0.03%		 0 / 0
0%		 -8 / -11
-0.02%

@github-actions GitHub Actions
Copy link
Contributor

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-lsexbfygtt.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-pnrgldjalu.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@JamesBurnside JamesBurnside changed the title Support HMR in our samples Support HMR for codespaces development in our samples Aug 28, 2024
@JamesBurnside JamesBurnside changed the title Support HMR for codespaces development in our samples Support HMR for codespaces development in our test apps Aug 28, 2024
@JamesBurnside JamesBurnside marked this pull request as ready for review August 28, 2024 22:09
@JamesBurnside JamesBurnside requested review from a team as code owners August 28, 2024 22:09
@Leah-Xia-Microsoft
Copy link
Member

Verified on Mac locally and on Codespace. Nice feature.

@JamesBurnside JamesBurnside enabled auto-merge (squash) August 29, 2024 15:48
@JamesBurnside JamesBurnside merged commit 3d74079 into main Aug 29, 2024
40 checks passed
@JamesBurnside JamesBurnside deleted the jaburnsi/HMR-sample-support branch August 29, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmceachernmsft dmceachernmsft dmceachernmsft approved these changes

@Leah-Xia-Microsoft Leah-Xia-Microsoft Leah-Xia-Microsoft approved these changes

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@PorterNan PorterNan Awaiting requested review from PorterNan PorterNan is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@mgamis-msft mgamis-msft

@dmceachernmsft dmceachernmsft

@Leah-Xia-Microsoft Leah-Xia-Microsoft

Labels
does not need changelog Changes that does not affect the published package in any way do not need changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JamesBurnside @Leah-Xia-Microsoft @dmceachernmsft @mgamis-msft