-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesigned architecture to support multiple LLM services in Co-op Translator #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gration - Restructure configuration system for modular provider management - Separate provider-specific implementations into dedicated modules - Implement abstract base classes for LLM and Vision services - Move common utilities to appropriate subdirectories - Update import paths to reflect new architecture This redesign allows for easier integration of new language and vision models while maintaining clean separation of concerns.
github-actions
bot
added
translator
Related to any changes in the translation-related source files
tests
labels
Dec 19, 2024
2 tasks
skytin1004
changed the title
Redesign architecture for flexible LLM/Vision providers
Redesign architecture for support for multiple LLM services in Co-op Translator
Dec 19, 2024
skytin1004
changed the title
Redesign architecture for support for multiple LLM services in Co-op Translator
Redesigned architecture to support multiple LLM services in Co-op Translator
Dec 19, 2024
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Dec 19, 2024
github-actions
bot
added
the
build
Related to the build process, dependency management, and CI/CD configurations
label
Dec 20, 2024
I have reviewed the changes and everything looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build
Related to the build process, dependency management, and CI/CD configurations
documentation
Improvements or additions to documentation
enhancement
New feature or request
tests
translator
Related to any changes in the translation-related source files
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This redesign allows for easier integration of new language and vision models while maintaining clean separation of concerns.
Solved #56
Purpose
This redesign aims to make the codebase more extensible and maintainable by:
Description
Major changes include:
Configuration System Restructuring
Service Layer Reorganization
Utility Reorganization
utils/common
utils/llm
utils/vision
Related Issue
N/A - Architecture improvement initiative
Does this introduce a breaking change?
Type of change
Checklist
Before submitting your pull request, please confirm the following:
Additional context
This refactoring sets the foundation for:
Functional testing complete. OpenAI model confirmed to work correctly. Test code will be added later.