allowUsingHttp2 #42947
Open
allowUsingHttp2 #42947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinlian12
force-pushed
the
enableHttp2ForTest
branch
from
128a645
to
e3939b3
Compare
|
/azp run java - cosmos - tests |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
API change check API changes are not detected in this pull request. |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| // Check for leading whitespace or other prohibited characters | ||
| if (StringUtils.isNotEmpty(value) && (value.charAt(0) == ' ' || value.charAt(value.length() - 1) == ' ')) { | ||
| // Clean up the header value by trimming or handling as needed | ||
| logger.warn("There are extra white space for key {} with value {}", key, value); |
There was a problem hiding this comment.
Given taht this happens for each request now - maybe make this DEBUG level tracing for now?
There was a problem hiding this comment.
make sense - will change in next iteration
There was a problem hiding this comment.
changed to trace level
| @@ -59,6 +59,8 @@ static HttpClient createFixed(HttpClientConfig httpClientConfig) { | |||
| fixedConnectionProviderBuilder.pendingAcquireTimeout(connectionAcquireTimeout); | |||
| fixedConnectionProviderBuilder.maxIdleTime(maxIdleConnectionTimeoutInMillis); | |||
|
|
|||
| // TODO[Http2]: config Http2AllocationStrategy (maxConnections & maxConcurrentStreams) | |||
There was a problem hiding this comment.
I assume left out intentionally instead of using 30 for maxConcurrentStreams?
There was a problem hiding this comment.
yea want to wire it up when adding the public API change
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.