Remove GuestAttestation logic #23338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
️✔️Az.ApplicationInsights
️✔️Az.Compute
️✔️Az.EventHub
️✔️Az.KeyVault
️✔️Az.ManagedServiceIdentity
️✔️Az.Monitor
️✔️Az.Network
️✔️Az.OperationalInsights
️✔️Az.PrivateDns
️✔️Az.RecoveryServices
️✔️Az.Security
️✔️Az.Sql
️✔️Az.Ssh
️✔️Az.Storage
|
|
let's add a test creating a VMSS defaulting in both TL and Flex, that was failing before, should pass here. Also this seems to contain reverting #23297, which is good. |
Sandido
added this to the Az 11.0.0 (November 2023, 2023-11-14)❗ Breaking change release ❗ milestone
Sandido
requested review from
bilaakpan-ms,
haagha and
grizzlytheodore
as code owners
|
LGTM thank you adam |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trusted Launch is now turned on by default: #22974
As part of this, the GuestAttestation extension is installed on the VM and Vmss by default and sets SystemAssignedIdentity to True. This feature specifically only occurred when the user explicitly set TrustedLaunch.
The GuestAttestation extension was removed from other clients due to perf concerns. It adds to our perf by increasing it by about 10%. Considering this needs to be done in a breaking change release, we would like to remove it now.
This PR also reverts logic that was added into the Vmss creation code to set SystemAssignedIdentity from True back to False if the vmss is a Flexible orchestration mode since SystemAssigned is not allowed and will cause the Vmss creation to fail (by default since Flex is also now turned on by default. This hotfix logic is not needed if the entire GuestAttestation logic is removed.
While this is an unannounced breaking change,
is worth the break.
Checklist
CONTRIBUTING.mdand reviewed the following information:generationbranch.ChangeLog.mdfile(s) appropriatelyChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader in the past tense. Add changelog in description section if PR goes intogenerationbranch.ChangeLog.mdif no new release is required, such as fixing test case only.