adding new option for network check in persist_firewall test #3257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagworld9
requested review from
narrieta,
ZhidongPeng and
maddieford
as code owners
maddieford
reviewed
Nov 8, 2024
| if [[ $? -eq 0 ]]; then | ||
| echo "Network is accessible" | ||
| return 0 | ||
| else: |
There was a problem hiding this comment.
I think this else: may be a syntax error
maddieford
previously approved these changes
Nov 8, 2024
narrieta
reviewed
Nov 9, 2024
|
|
||
| echo "$(date --utc +%FT%T.%3NZ): Network still not accessible" | ||
| echo "Unable to connect to network, giving up" | ||
| retun 1 |
narrieta
approved these changes
Nov 12, 2024
maddieford
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We use ping to 8.8.8.8 to verify network connectivity before we verify firewall rules was added at boot before network is ready.
Seems ping check not reliable way to verify network is ready. It keeps failing even though network seem ok in the system.
Now I added different option which calls ipconfig.io service. We assume network is ready if this call succeeds. Adding as temporary option, if it's fails, we check ping 8.8.8.8 also fails or not. Later, if this option looks stable, we remove other options.
This pr also adding fix for iptables command not found issue
Issue #
PR information
Quality of Code and Contribution Guidelines