Rework FreeBSDResourceDiskHandler #1892
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwhsu
requested review from
larohra,
narrieta,
pgombar and
ZhidongPeng
as code owners
|
|
Codecov Report
@@ Coverage Diff @@
## develop #1892 +/- ##
===========================================
- Coverage 71.95% 70.40% -1.55%
===========================================
Files 104 97 -7
Lines 15765 14053 -1712
Branches 2244 2026 -218
===========================================
- Hits 11343 9894 -1449
+ Misses 3906 3712 -194
+ Partials 516 447 -69
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
narrieta
requested review from
trstringer
and removed request for
ZhidongPeng,
narrieta,
pgombar and
larohra
lwhsu
force-pushed
the
freebsd-resourcedisk
branch
2 times, most recently
from
65e7a56
to
2bfe70d
Compare
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
May 23, 2020
- Pull in the patch from Azure/WALinuxAgent#1892 - Drop patch to create large swap space, leave some more space for temporarily storage Approved by: maintainer (implicitly) Sponsored by: The FreeBSD Foundation git-svn-id: svn+ssh://svn.freebsd.org/ports/head@536262 35697150-7ecd-e111-bb59-0022644237b5
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
May 23, 2020
- Pull in the patch from Azure/WALinuxAgent#1892 - Drop patch to create large swap space, leave some more space for temporarily storage Approved by: maintainer (implicitly) Sponsored by: The FreeBSD Foundation
Jehops
pushed a commit
to Jehops/freebsd-ports-legacy
that referenced
this pull request
May 23, 2020
- Pull in the patch from Azure/WALinuxAgent#1892 - Drop patch to create large swap space, leave some more space for temporarily storage Approved by: maintainer (implicitly) Sponsored by: The FreeBSD Foundation git-svn-id: svn+ssh://svn.freebsd.org/ports/head@536262 35697150-7ecd-e111-bb59-0022644237b5
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
May 26, 2020
Adjust WALinuxAgent to be more sutiable for FreeBSD: - Pull in the patch from Azure/WALinuxAgent#1892 - Drop patch to create large swap space, leave some more space for temporarily storage Approved by: maintainer (implicitly) Sponsored by: The FreeBSD Foundation Approved by: portmgr (bapt)
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Apr 1, 2021
Adjust WALinuxAgent to be more sutiable for FreeBSD: - Pull in the patch from Azure/WALinuxAgent#1892 - Drop patch to create large swap space, leave some more space for temporarily storage Approved by: maintainer (implicitly) Sponsored by: The FreeBSD Foundation Approved by: portmgr (bapt)
lwhsu
force-pushed
the
freebsd-resourcedisk
branch
from
22fdbdc
to
7b65f8e
Compare
lwhsu
force-pushed
the
freebsd-resourcedisk
branch
4 times, most recently
from
aedf335
to
6eb63a4
Compare
|
@trstringer Please review and merge this. Thanks! |
lwhsu
force-pushed
the
freebsd-resourcedisk
branch
from
6eb63a4
to
9039cec
Compare
lwhsu
force-pushed
the
freebsd-resourcedisk
branch
from
9039cec
to
88ad74e
Compare
Replace using a swap file in the file system of the resource disk by using a swap partition, which is the preferred swap device. This also avoids using the slower posix_fallocate(2) and helps increasing VM provision speed.
lwhsu
force-pushed
the
freebsd-resourcedisk
branch
from
88ad74e
to
54de935
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace using a swap file in the file system of the resource disk by
using a swap partition, which is the preferred swap device. This also
avoids using the slower posix_fallocate(2) and helps increasing VM
provision speed.
Also add support for generation 2 VMs.
PR information
Quality of Code and Contribution Guidelines