Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add switch to turn redundant log file off #1819

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

pmjdebruijn
Copy link
Contributor

@pmjdebruijn pmjdebruijn commented Mar 18, 2020

Description

Issue #1817 (this adds on option for the last part, without actually changing the default behavior)

Currently there is no way to disable logging to /var/log/waagent.log, which is redundant with the proper system log in journald.

This PR adds a configuration switch so it's easy to turn off logging to a file, and only have logging in journald.


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines


This change is Reviewable

@msftclas
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ pmjdebruijn sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #1819 into develop will decrease coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1819      +/-   ##
===========================================
- Coverage    68.54%   68.54%   -0.01%     
===========================================
  Files           82       82              
  Lines        11729    11732       +3     
  Branches      1644     1645       +1     
===========================================
+ Hits          8040     8042       +2     
  Misses        3343     3343              
- Partials       346      347       +1     
Impacted Files Coverage Δ
azurelinuxagent/agent.py 44.37% <50.00%> (-0.28%) ⬇️
azurelinuxagent/common/conf.py 79.06% <100.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10ae95b...aa9a8f9. Read the comment docs.

@vrdmr vrdmr removed their request for review April 23, 2020 00:06
@pgombar pgombar self-assigned this Jul 16, 2020
@pgombar pgombar removed their assignment Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants