Allow for more fine tune provisioning options #1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AZaugg
requested review from
larohra,
narrieta,
pgombar and
vrdmr
as code owners
|
|
|
@anhvoms @trstringer - Could you please take a look at this? This is from the offline discussion you had with @AZaugg. |
anhvoms
previously approved these changes
Jun 23, 2020
trstringer
previously approved these changes
Jun 23, 2020
narrieta
reviewed
Jun 23, 2020
narrieta
reviewed
Jun 23, 2020
narrieta
reviewed
Jun 23, 2020
Allow a user to better control what WAAgent provisions during a Provisioning event. Allow the user to control if, useraccounts, hostname and custom data be set.
Allow a user to better control what WAAgent provisions during a Provisioning event. Allow the user to control if, useraccounts, hostname and custom data be set.
trstringer
suggested changes
Nov 10, 2020
| _Type: Boolean_ | ||
| _Default: y_ | ||
|
|
||
| Control if WAAgent should attempt to set the VMs hostname |
There was a problem hiding this comment.
Could you explain when this would be used? Perhaps add an example for when you would want to change from the default and not set the hostname.
Nit: periods at the end of the sentence for document consistency.
| _Type: Boolean_ | ||
| _Default: y_ | ||
|
|
||
| Control if WAAgent should configure user accounts |
There was a problem hiding this comment.
Same as above. Maybe add an example usage when you wouldn't want to configure user accounts.
Nit: period at the end of the sentence for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow a user to better control what WAAgent provisions during a
Provisioning event. Allow the user to control if, useraccounts, hostname
and custom data be set.
Description
Issue #
PR information
Quality of Code and Contribution Guidelines
This change is