feat: do not download reference CNI plugins #4597
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulgmiller
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
ShiqianTao,
AbelHu,
junjiezhang1997,
jason1028kr and
djsly
as code owners
| @@ -33,7 +33,6 @@ SERVICE_PRINCIPAL_CLIENT_ID={{.AuthConfig.GetServicePrincipalId}} | |||
| NETWORK_PLUGIN={{getStringFromNetworkPluginType .GetNetworkConfig.GetNetworkPlugin}} | |||
| NETWORK_POLICY="{{getStringFromNetworkPolicyType .GetNetworkConfig.GetNetworkPolicy}}" | |||
| VNET_CNI_PLUGINS_URL={{.GetNetworkConfig.GetVnetCniPluginsUrl}} | |||
| CNI_PLUGINS_URL={{.GetNetworkConfig.GetCniPluginsUrl}} | |||
There was a problem hiding this comment.
cc @lilypan26 @anujmaheshwari1 for bootstrap contract changes
There was a problem hiding this comment.
hoping rp can drop this too.
| # and how is that different from AgentBaker/vhdbuilder/packer/components.json | ||
| #Only the seconde one caches arm? | ||
| if [[ $(isARM64) == 1 ]]; then | ||
| CNI_TGZ_TMP="cni-plugins-linux-arm64-v1.4.1.tgz" |
There was a problem hiding this comment.
we're currently working on revamping all of our component download/install logic to reference versions baked into components.json, thus we'd want to use that here as well
There was a problem hiding this comment.
Can I be a beta tester here?
cameronmeissner
changed the title
|
also, |
|
|
||
| # Is there a ${arch} variable I can use instead of the iff |
There was a problem hiding this comment.
seems CPU_ARCH will already be defined at the global scope during build, though I guess installCNI will only ever be called at runtime after Devin's changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature (kind of more removing a feature)
What this PR does / why we need it:
Reference CNI plugins were formally able to be downloaded from a share however this just caused out of sync issues and was not really used since a node image upgrade was still required. This just always uses the version cached on the vhd
Very open to suggestions on which components.json is used, if it should cache arm64 and amd64 and how to not have to sync vesions between compoennts.json and cse.sh.
Which issue(s) this PR fixes:
none
Requirements:
uses conventional commit messages
includes documentation
adds unit tests
tested upgrade from previous version
Special notes for your reviewer:
Release note: