fix: resolve duplicate rsyslog entries for Azure Linux #4588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9784181482Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9784192610Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9786964606Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
henryli001
force-pushed
the
lihl/fix-duplicate-syslog
branch
from
9a4d84f
to
abcc3b8
Compare
Pull Request Test Coverage Report for Build 9811824468Details
💛 - Coveralls |
henryli001
force-pushed
the
lihl/fix-duplicate-syslog
branch
from
abcc3b8
to
baef5cd
Compare
henryli001
requested review from
juan-lee,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
ShiqianTao,
AbelHu,
junjiezhang1997,
jason1028kr and
djsly
as code owners
Pull Request Test Coverage Report for Build 9813113656Details
💛 - Coveralls |
dallasd1
approved these changes
Jul 8, 2024
|
lgtm pending green abe2e run |
Pull Request Test Coverage Report for Build 9879732586Details
💛 - Coveralls |
|
@cameronmeissner all checks including AgentBaker E2E has passed. |
cameronmeissner
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR aims to fix the issue of duplicate entries in /var/log/messages file in Azure Linux AKS.
The default rsyslog configuration file (/etc/rsyslog.conf) in Azure Linux contains the following setting:
*.*,auth,authpriv,mail,cron.none -/var/log/messagesThe 60-CIS.conf file provided by AgentBaker contains the following setting:
*.*;mail.none;news.none -/var/log/messagesThe duplicate specification of
*.*is the reason why logs are written twice into /var/log/messages. The default setting in Azure Linux cannot be modified as that will affect the standard Azure Linux images and thus this PR makes the fix in the AgentBaker repo to not apply*.*twice for Azure Linux AKS container host.Bug link: https://microsoft.visualstudio.com/OS/_workitems/edit/50154304/
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: