cleanup: remove kube-proxy-images.json #4556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason1028kr
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
ShiqianTao,
AbelHu,
junjiezhang1997 and
djsly
as code owners
Pull Request Test Coverage Report for Build 9687522233Details
💛 - Coveralls |
jason1028kr
force-pushed
the
jasonjung/migrate-k8s-proxy
branch
from
8eb3a1f
to
28cc2a0
Compare
jason1028kr
changed the title
Pull Request Test Coverage Report for Build 9687550537Details
💛 - Coveralls |
jason1028kr
force-pushed
the
jasonjung/migrate-k8s-proxy
branch
from
28cc2a0
to
c882aab
Compare
Pull Request Test Coverage Report for Build 9687655292Details
💛 - Coveralls |
| @@ -381,6 +381,29 @@ | |||
| "multiArchVersions": [ | |||
| "v0.7.1" | |||
| ] | |||
| }, | |||
| { | |||
| "downloadURL": "mcr.microsoft.com/oss/kubernetes/kube-proxy:*", | |||
There was a problem hiding this comment.
doesn't seem like we're actually using this during VHD builds (install-dependencies.sh), are we not supposed to be caching this anymore?
There was a problem hiding this comment.
confirmed offline that we still aim to cache this, should probably wait on merging this until after @Devinwong's change merge into master
There was a problem hiding this comment.
Wouldn't this loop https://github.com/Azure/AgentBaker/pull/4556/files#diff-d6aeb8e845af4c32251915a17dc7c887d73cd628262e83118b9dcd65f7728c98L312-R343 cover the added json entry under 'containerImages' key? I couldn't properly check b/c test pipeline was failing for other reasons, but I'll confirm once that's unblocked. I can also just pause until schema's finalized as you suggested.
There was a problem hiding this comment.
ah, yes you're right :)
approved, up to you whether you wanna merge now before Devin's changes or wait until the schema is updated
Pull Request Test Coverage Report for Build 9716172770Details
💛 - Coveralls |
cameronmeissner
approved these changes
Jul 1, 2024
jason1028kr
force-pushed
the
jasonjung/migrate-k8s-proxy
branch
from
816bf11
to
b527914
Compare
Pull Request Test Coverage Report for Build 9748402800Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9753410800Details
💛 - Coveralls |
djsly
reviewed
Jul 2, 2024
| { | ||
| "downloadURL": "mcr.microsoft.com/oss/kubernetes/kube-proxy:*", | ||
| "amd64OnlyVersions": [], | ||
| "multiArchVersions": [ |
There was a problem hiding this comment.
that's way too may version. after we review the Schema, we will need to keep 3 images only (one per AKS versions)
There was a problem hiding this comment.
I believe we'll need to keep corresponding kube-proxy version for each unique major.minor.patch k8s version
jason1028kr
force-pushed
the
jasonjung/migrate-k8s-proxy
branch
from
ad87a70
to
7c70b35
Compare
Pull Request Test Coverage Report for Build 9814673025Details
💛 - Coveralls |
jason1028kr
force-pushed
the
jasonjung/migrate-k8s-proxy
branch
from
7c70b35
to
2d9b631
Compare
jason1028kr
changed the title
Pull Request Test Coverage Report for Build 9961922027Details
💛 - Coveralls |
jason1028kr
force-pushed
the
jasonjung/migrate-k8s-proxy
branch
from
2d9b631
to
d7de5d9
Compare
Devinwong
approved these changes
Jul 12, 2024
jason1028kr
force-pushed
the
jasonjung/migrate-k8s-proxy
branch
from
d7de5d9
to
52e2b3a
Compare
jason1028kr
force-pushed
the
jasonjung/migrate-k8s-proxy
branch
from
52e2b3a
to
e988c7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
remove kube-proxy-image.json
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: