Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: container insights release 3.1.22 and win-3.1.22 #4555

Merged
merged 5 commits into from
Jul 10, 2024
Merged

feat: container insights release 3.1.22 and win-3.1.22 #4555

merged 5 commits into from
Jul 10, 2024

Conversation

wanlonghenry
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@wanlonghenry wanlonghenry changed the title feat: container insights release 3.1.21 and win-3.1.21 feat: container insights release 3.1.22 and win-3.1.22 Jun 26, 2024
@coveralls
Copy link

coveralls commented Jun 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9684881063

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.486%
Totals Coverage Status
Change from base Build 9674880013: 0.0%
Covered Lines: 2627
Relevant Lines: 3727
💛 - Coveralls

@ganga1980 ganga1980 enabled auto-merge (squash) June 26, 2024 18:34
@AbelHu AbelHu added the VHD your change will be included in the following VHDs label Jun 27, 2024
@coveralls
Copy link

coveralls commented Jun 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9693279254

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.486%
Totals Coverage Status
Change from base Build 9693263400: 0.0%
Covered Lines: 2627
Relevant Lines: 3727
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9707765244

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.486%
Totals Coverage Status
Change from base Build 9707744418: 0.0%
Covered Lines: 2627
Relevant Lines: 3727
💛 - Coveralls

junjiezhang1997
junjiezhang1997 reviewed Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@junjiezhang1997 junjiezhang1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cameronmeissner Linux pipelines failed due to capacity issue in eastus. Could you please take a look?

@djsly
Copy link
Contributor

djsly commented Jun 28, 2024

@cameronmeissner Linux pipelines failed due to capacity issue in eastus. Could you please take a look?

@junjiezhang1997 we are working on changing the Packer build azure location outside of the affected eastus, until this is completed, the pipeline tests will be flaky

@junjiezhang1997
Copy link
Collaborator

junjiezhang1997 commented Jul 1, 2024 •
edited
Loading

@cameronmeissner Linux pipelines failed due to capacity issue in eastus. Could you please take a look?

@junjiezhang1997 we are working on changing the Packer build azure location outside of the affected eastus, until this is completed, the pipeline tests will be flaky

@djsly Could we bypass these flaky tests now since they are required to merge the PR?

@coveralls
Copy link

coveralls commented Jul 1, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9736838560

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.486%
Totals Coverage Status
Change from base Build 9718319384: 0.0%
Covered Lines: 2627
Relevant Lines: 3727
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9753638971

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.486%
Totals Coverage Status
Change from base Build 9753173800: 0.0%
Covered Lines: 2627
Relevant Lines: 3727
💛 - Coveralls

@wanlonghenry wanlonghenry enabled auto-merge (squash) July 2, 2024 16:26
@coveralls
Copy link

coveralls commented Jul 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9769388684

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.486%
Totals Coverage Status
Change from base Build 9765241504: 0.0%
Covered Lines: 2627
Relevant Lines: 3727
💛 - Coveralls

@AbelHu AbelHu enabled auto-merge (squash) July 2, 2024 23:39
@cameronmeissner
Copy link
Collaborator

any reason we're still waiting to merge?

@ganga1980
Copy link
Contributor

any reason we're still waiting to merge?

there is no reason to wait if all the PR gates passed. enabled auto-merge and hopefully, this time this should get merged.

auto-merge was automatically disabled July 5, 2024 19:24

Pull Request is not mergeable

auto-merge was automatically disabled July 5, 2024 19:24

Pull Request is not mergeable

@wanlonghenry wanlonghenry enabled auto-merge (squash) July 5, 2024 19:31
@coveralls
Copy link

coveralls commented Jul 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9812852058

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.486%
Totals Coverage Status
Change from base Build 9811870560: 0.0%
Covered Lines: 2627
Relevant Lines: 3727
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 8, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9851633670

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.486%
Totals Coverage Status
Change from base Build 9849658700: 0.0%
Covered Lines: 2627
Relevant Lines: 3727
💛 - Coveralls

@AbelHu AbelHu disabled auto-merge July 10, 2024 02:54
@AbelHu AbelHu merged commit a3fdb40 into master Jul 10, 2024
22 of 26 checks passed
@AbelHu AbelHu deleted the longw/releases-3.1.22 branch July 10, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junjiezhang1997 junjiezhang1997 junjiezhang1997 left review comments

@djsly djsly djsly approved these changes

@ganga1980 ganga1980 ganga1980 approved these changes

@cameronmeissner cameronmeissner cameronmeissner approved these changes

@juan-lee juan-lee Awaiting requested review from juan-lee juan-lee is a code owner

@UtheMan UtheMan Awaiting requested review from UtheMan UtheMan is a code owner

@ganeshkumarashok ganeshkumarashok Awaiting requested review from ganeshkumarashok ganeshkumarashok is a code owner

@anujmaheshwari1 anujmaheshwari1 Awaiting requested review from anujmaheshwari1 anujmaheshwari1 is a code owner

@AlisonB319 AlisonB319 Awaiting requested review from AlisonB319 AlisonB319 is a code owner

@Devinwong Devinwong Awaiting requested review from Devinwong Devinwong is a code owner

@lilypan26 lilypan26 Awaiting requested review from lilypan26 lilypan26 is a code owner

@ShiqianTao ShiqianTao Awaiting requested review from ShiqianTao ShiqianTao is a code owner

@AbelHu AbelHu Awaiting requested review from AbelHu AbelHu is a code owner

@jason1028kr jason1028kr Awaiting requested review from jason1028kr jason1028kr is a code owner

Assignees
No one assigned
Labels
VHD your change will be included in the following VHDs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@wanlonghenry @coveralls @djsly @junjiezhang1997 @cameronmeissner @ganga1980 @AbelHu