Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: init vuln-to-kusto step #4554

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

feat: init vuln-to-kusto step #4554

wants to merge 9 commits into from

Conversation

bcho
Copy link
Member

@bcho bcho commented Jun 26, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@coveralls
Copy link

coveralls commented Jun 26, 2024

Pull Request Test Coverage Report for Build 9674497628

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.486%

Totals Coverage Status
Change from base Build 9671901246: 0.0%
Covered Lines: 2627
Relevant Lines: 3727

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 27, 2024

Pull Request Test Coverage Report for Build 9703441831

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 88 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 70.486%

Files with Coverage Reduction New Missed Lines %
pkg/agent/bakerapi.go 10 91.53%
pkg/agent/baker.go 78 71.64%
Totals Coverage Status
Change from base Build 9671901246: 0.0%
Covered Lines: 2627
Relevant Lines: 3727

💛 - Coveralls

@bcho bcho closed this Jun 27, 2024
@coveralls
Copy link

coveralls commented Jul 3, 2024

Pull Request Test Coverage Report for Build 9785288967

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.486%

Totals Coverage Status
Change from base Build 9783805229: 0.0%
Covered Lines: 2627
Relevant Lines: 3727

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 3, 2024

Pull Request Test Coverage Report for Build 9785289030

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.486%

Totals Coverage Status
Change from base Build 9783805229: 0.0%
Covered Lines: 2627
Relevant Lines: 3727

💛 - Coveralls

scriptLocation: 'inlineScript'
inlineScript: |
export AZCOPY_AUTO_LOGIN_TYPE=AZCLI
azcopy copy https://vulntokustobinary.blob.core.windows.net/vuln-to-kusto/v0.0.1-ee36fabc1ec4f415a022042ea89f751bf05da6ef/vuln-to-kusto-vhd_Linux_x86_64 ./vuln-to-kusto
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming this storage is locked down? does that mean we're already able to pull from it using the agent identity?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep the storage account is private and configured to be accessible with the identity used in this step (agentbaker-vuln-to-kusto)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9871536617

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.486%

Totals Coverage Status
Change from base Build 9869024572: 0.0%
Covered Lines: 2627
Relevant Lines: 3727

💛 - Coveralls

Copy link
Collaborator

@cameronmeissner cameronmeissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for now, feel free to ping me for a further review if you need it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants