Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support kubelet server certificate rotation #4546

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

cameronmeissner
Copy link
Collaborator

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@cameronmeissner cameronmeissner changed the title Cameissner/rotate server certificates feat: support kubelet server certificate rotation Jun 21, 2024
@coveralls
Copy link

coveralls commented Jun 21, 2024

Pull Request Test Coverage Report for Build 9617595817

Details

  • 23 of 27 (85.19%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 76.026%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/agent/utils.go 18 22 81.82%
Totals Coverage Status
Change from base Build 9610979529: 0.06%
Covered Lines: 2648
Relevant Lines: 3483

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 24, 2024

Pull Request Test Coverage Report for Build 9650980015

Details

  • 23 of 27 (85.19%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 76.026%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/agent/utils.go 18 22 81.82%
Totals Coverage Status
Change from base Build 9638714944: 0.06%
Covered Lines: 2648
Relevant Lines: 3483

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 24, 2024

Pull Request Test Coverage Report for Build 9651029644

Details

  • 25 of 31 (80.65%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 75.997%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/agent/utils.go 20 26 76.92%
Totals Coverage Status
Change from base Build 9638714944: 0.03%
Covered Lines: 2650
Relevant Lines: 3487

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants