cleanup: use url from manifest.cue to download k8s #4443
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmy-wright
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
ShiqianTao,
AbelHu,
junjiezhang1997,
jason1028kr and
djsly
as code owners
Pull Request Test Coverage Report for Build 9396018292Details
💛 - Coveralls |
djsly
reviewed
May 29, 2024
timmy-wright
force-pushed
the
wrightt/use_url_in_manifest
branch
from
e76d1cd
to
8378680
Compare
timmy-wright
force-pushed
the
wrightt/use_url_in_manifest
branch
from
8378680
to
2df3789
Compare
timmy-wright
force-pushed
the
wrightt/use_url_in_manifest
branch
from
2df3789
to
253b6f5
Compare
4 tasks
djsly
approved these changes
Jun 4, 2024
timmy-wright
force-pushed
the
wrightt/use_url_in_manifest
branch
from
253b6f5
to
e048d27
Compare
djsly
reviewed
Jun 6, 2024
| if: always() | ||
| with: | ||
| files: | | ||
| test-results/**/*.xml |
There was a problem hiding this comment.
I forgot does the glob pattern ** also looks in the current dir ? Since test-results/bats_shell.junit.xml is not found in any subdirectory
djsly
reviewed
Jun 6, 2024
| assert_called rm -f /var/lib/man-db/auto-update | ||
| } | ||
|
|
||
| @test "failing test" { |
There was a problem hiding this comment.
I'm guessing this is simply to test that the logic works and it's not tone committed ?
cameronmeissner
requested changes
Jun 21, 2024
|
closing for now, feel free to reopen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Start getting all config information from manifest.json/cue instead of hardcoding it.
Which issue(s) this PR fixes:
Requirements:
Special notes for your reviewer:
Release note: