Skip to content

Commit

Permalink
feat: do not increment reference counts on arrays through references (n…
Browse files Browse the repository at this point in the history
…oir-lang/noir#6375)

fix: (LSP) check visibility of module that re-exports item, if any (noir-lang/noir#6371)
feat: let LSP suggest traits in trait bounds (noir-lang/noir#6370)
fix: LSP auto-import would import public item inside private module (noir-lang/noir#6366)
fix: remove assumed parent traits (noir-lang/noir#6365)
fix: slightly better formatting of empty blocks with comments (noir-lang/noir#6367)
fix: Fix panic in comptime code (noir-lang/noir#6361)
feat: let the LSP import code action insert into existing use statements (noir-lang/noir#6358)
chore: minor tweaks to comptime doc (noir-lang/noir#6357)
feat: LSP auto-import will try to add to existing use statements (noir-lang/noir#6354)
fix: allow type aliases in let patterns (noir-lang/noir#6356)
feat(test): Run test matrix on stdlib tests (noir-lang/noir#6352)
fix(ssa): Do not mark an array from a parameter mutable (noir-lang/noir#6355)
fix: always inline `derive_generators` (noir-lang/noir#6350)
chore: add test to check that duplicate definitions generated from macros throws error (noir-lang/noir#6351)
  • Loading branch information
AztecBot committed Oct 29, 2024
2 parents 2dc8469 + 8861dd9 commit f646681
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .noir-sync-commit
Original file line number Diff line number Diff line change
@@ -1 +1 @@
a4fc6e861492ab5ff12ebc5fdbb248f983eab0a2
60c770f5f2594eea31ac75c852980edefa40d9eb
Original file line number Diff line number Diff line change
Expand Up @@ -442,13 +442,7 @@ impl FunctionBuilder {
match self.type_of_value(value) {
Type::Numeric(_) => (),
Type::Function => (),
Type::Reference(element) => {
if element.contains_an_array() {
let reference = value;
let value = self.insert_load(reference, element.as_ref().clone());
self.update_array_reference_count(value, increment);
}
}
Type::Reference(_) => (),
Type::Array(..) | Type::Slice(..) => {
// If there are nested arrays or slices, we wait until ArrayGet
// is issued to increment the count of that array.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ fn allows_references_to_structs_generated_by_macros() {
fn errors_if_macros_inject_functions_with_name_collisions() {
let src = r#"
comptime fn make_colliding_functions(_s: StructDefinition) -> Quoted {
quote {
quote {
fn foo() {}
}
}
Expand Down

0 comments on commit f646681

Please sign in to comment.