-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Json Graph Traversal Algorithm #431
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tweaked human facing punctuation, spelling, etc.
src/containers/Editor/components/views/GraphView/lib/utils/traverse.ts
Outdated
Show resolved
Hide resolved
src/containers/Editor/components/views/GraphView/lib/utils/traverse.ts
Outdated
Show resolved
Hide resolved
src/containers/Editor/components/views/GraphView/lib/utils/traverse.ts
Outdated
Show resolved
Hide resolved
src/containers/Editor/components/views/GraphView/lib/utils/traverse.ts
Outdated
Show resolved
Hide resolved
src/containers/Editor/components/views/GraphView/lib/utils/traverse.ts
Outdated
Show resolved
Hide resolved
src/containers/Editor/components/views/GraphView/lib/utils/traverse.ts
Outdated
Show resolved
Hide resolved
Can I work on this. |
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Good job! It doesn't seem to work with arrays right now. |
@AykutSarac Can you provide the failing array case that you found? Or is it the way arrays are being unpacked? |
It happened when I wrapped the default JSON within an array []. |
@AykutSarac I think I fixed the array issue you pointed out! Thanks for assistance with testing the change. Here is the format of the json when we wrap the whole example in an array: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trivial, human-facing
src/containers/Editor/components/views/GraphView/lib/utils/traverse.ts
Outdated
Show resolved
Hide resolved
src/containers/Editor/components/views/GraphView/lib/utils/traverse.ts
Outdated
Show resolved
Hide resolved
…verse.ts Co-authored-by: Ted Thibodeau Jr <[email protected]>
…verse.ts Co-authored-by: Ted Thibodeau Jr <[email protected]>
This PR updates the JSON traversal algorithm to build the underlying graph structure that jsoncrack uses. There are a couple of changes that also address a bug in graph construction. Below is a screenshot better detailing the changes:
Fixes #385